* [PATCH] route_bench: Filter out all responses.
@ 2011-02-20 22:04 David Miller
2011-02-20 22:28 ` Pablo Neira Ayuso
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2011-02-20 22:04 UTC (permalink / raw)
To: netdev; +Cc: pablo
Install a socket filter to reduce the pure netlink overhead.
Unfortunately the libmnl library does not provide a way to
set socket options that are of level other than SOL_NETLINK.
So we hack it by knowing some things about libmnl internals.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
The knowledge of libmnl internals is unfortunate, but there
is currently no other way to do this.
route_bench.c | 33 +++++++++++++++++++++++++--------
1 files changed, 25 insertions(+), 8 deletions(-)
diff --git a/route_bench.c b/route_bench.c
index c75ea45..6c6b525 100644
--- a/route_bench.c
+++ b/route_bench.c
@@ -22,6 +22,17 @@
#include <linux/if.h>
#include <linux/if_link.h>
#include <linux/rtnetlink.h>
+#include <linux/filter.h>
+
+/* XXX Ugly knowledge of internals, but there is currently no way
+ * XXX provided by the libmnl library to set socket options that are
+ * XXX of level other than SOL_NETLINK. And we need to set one of
+ * XXX level SOL_SOCKET to install the socket filter.
+ */
+struct mnl_socket {
+ int fd;
+ struct sockaddr_nl addr;
+};
static int usage(void)
{
@@ -139,8 +150,10 @@ static int do_bench(int count, in_addr_t src_addr, in_addr_t dst_addr,
unsigned int mark, unsigned int iif)
{
char send_buf[MNL_SOCKET_BUFFER_SIZE];
- char recv_buf[MNL_SOCKET_BUFFER_SIZE];
unsigned int min, sec, frac, tmp;
+ struct sock_filter insns = { .code = BPF_RET | BPF_K,
+ .k = 0 };
+ struct sock_fprog filter = { .len = 1, .filter = &insns, };
struct bench_state *s = &state;
struct timeval start_time;
struct timeval end_time;
@@ -148,7 +161,7 @@ static int do_bench(int count, in_addr_t src_addr, in_addr_t dst_addr,
struct nlmsghdr *nlh;
unsigned int portid;
struct rtmsg *rtm;
- int i;
+ int i, err;
init_bench_state(s);
@@ -165,10 +178,15 @@ static int do_bench(int count, in_addr_t src_addr, in_addr_t dst_addr,
portid = mnl_socket_get_portid(nl);
+ err = setsockopt(nl->fd, SOL_SOCKET, SO_ATTACH_FILTER, &filter, sizeof(filter));
+ if (err) {
+ perror("setsockopt");
+ return -1;
+ }
+
gettimeofday(&start_time, NULL);
for (i = 0; i < count; i++) {
unsigned int seq;
- int ret;
nlh = mnl_nlmsg_put_header(send_buf);
nlh->nlmsg_type = RTM_GETROUTE;
@@ -197,11 +215,10 @@ static int do_bench(int count, in_addr_t src_addr, in_addr_t dst_addr,
perror("mnl_socket_sendto");
return -1;
}
- ret = mnl_socket_recvfrom(nl, recv_buf, sizeof(recv_buf));
- if (ret < 0) {
- perror("mnl_sock_recvfrom");
- return -1;
- }
+
+ /* No need to do a receive, as the socket filter rejects
+ * all packets.
+ */
advance_bench_state(s);
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] route_bench: Filter out all responses.
2011-02-20 22:04 [PATCH] route_bench: Filter out all responses David Miller
@ 2011-02-20 22:28 ` Pablo Neira Ayuso
2011-02-20 22:32 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Pablo Neira Ayuso @ 2011-02-20 22:28 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On 20/02/11 23:04, David Miller wrote:
>
> Install a socket filter to reduce the pure netlink overhead.
>
> Unfortunately the libmnl library does not provide a way to
> set socket options that are of level other than SOL_NETLINK.
>
> So we hack it by knowing some things about libmnl internals.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
>
> The knowledge of libmnl internals is unfortunate, but there
> is currently no other way to do this.
>
> route_bench.c | 33 +++++++++++++++++++++++++--------
> 1 files changed, 25 insertions(+), 8 deletions(-)
>
> diff --git a/route_bench.c b/route_bench.c
> index c75ea45..6c6b525 100644
> --- a/route_bench.c
> +++ b/route_bench.c
> @@ -22,6 +22,17 @@
> #include <linux/if.h>
> #include <linux/if_link.h>
> #include <linux/rtnetlink.h>
> +#include <linux/filter.h>
> +
> +/* XXX Ugly knowledge of internals, but there is currently no way
> + * XXX provided by the libmnl library to set socket options that are
> + * XXX of level other than SOL_NETLINK. And we need to set one of
> + * XXX level SOL_SOCKET to install the socket filter.
> + */
> +struct mnl_socket {
> + int fd;
> + struct sockaddr_nl addr;
> +};
>
> static int usage(void)
> {
> @@ -139,8 +150,10 @@ static int do_bench(int count, in_addr_t src_addr, in_addr_t dst_addr,
> unsigned int mark, unsigned int iif)
> {
> char send_buf[MNL_SOCKET_BUFFER_SIZE];
> - char recv_buf[MNL_SOCKET_BUFFER_SIZE];
> unsigned int min, sec, frac, tmp;
> + struct sock_filter insns = { .code = BPF_RET | BPF_K,
> + .k = 0 };
> + struct sock_fprog filter = { .len = 1, .filter = &insns, };
> struct bench_state *s = &state;
> struct timeval start_time;
> struct timeval end_time;
> @@ -148,7 +161,7 @@ static int do_bench(int count, in_addr_t src_addr, in_addr_t dst_addr,
> struct nlmsghdr *nlh;
> unsigned int portid;
> struct rtmsg *rtm;
> - int i;
> + int i, err;
>
> init_bench_state(s);
>
> @@ -165,10 +178,15 @@ static int do_bench(int count, in_addr_t src_addr, in_addr_t dst_addr,
>
> portid = mnl_socket_get_portid(nl);
>
> + err = setsockopt(nl->fd, SOL_SOCKET, SO_ATTACH_FILTER, &filter, sizeof(filter));
> + if (err) {
> + perror("setsockopt");
> + return -1;
> + }
> +
You can use:
extern int mnl_socket_get_fd(const struct mnl_socket *nl);
Thus, you can invoke setsockopt directly ;-).
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] route_bench: Filter out all responses.
2011-02-20 22:28 ` Pablo Neira Ayuso
@ 2011-02-20 22:32 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-02-20 22:32 UTC (permalink / raw)
To: pablo; +Cc: netdev
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Sun, 20 Feb 2011 23:28:15 +0100
> You can use:
>
> extern int mnl_socket_get_fd(const struct mnl_socket *nl);
>
> Thus, you can invoke setsockopt directly ;-).
Thank you, I didn't notice that interface.
I'll check in the following.
--------------------
route_bench: Remove knowledge of libmnl internals, not needed.
Since mnl_socket_get_fd() exists, we can use that.
Thanks to Pablo.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
route_bench.c | 13 ++-----------
1 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/route_bench.c b/route_bench.c
index 6c6b525..063b15e 100644
--- a/route_bench.c
+++ b/route_bench.c
@@ -24,16 +24,6 @@
#include <linux/rtnetlink.h>
#include <linux/filter.h>
-/* XXX Ugly knowledge of internals, but there is currently no way
- * XXX provided by the libmnl library to set socket options that are
- * XXX of level other than SOL_NETLINK. And we need to set one of
- * XXX level SOL_SOCKET to install the socket filter.
- */
-struct mnl_socket {
- int fd;
- struct sockaddr_nl addr;
-};
-
static int usage(void)
{
printf("usage: route_bench [ -o ] [ -l count ]\n");
@@ -178,7 +168,8 @@ static int do_bench(int count, in_addr_t src_addr, in_addr_t dst_addr,
portid = mnl_socket_get_portid(nl);
- err = setsockopt(nl->fd, SOL_SOCKET, SO_ATTACH_FILTER, &filter, sizeof(filter));
+ err = setsockopt(mnl_socket_get_fd(nl), SOL_SOCKET,
+ SO_ATTACH_FILTER, &filter, sizeof(filter));
if (err) {
perror("setsockopt");
return -1;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-20 22:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-20 22:04 [PATCH] route_bench: Filter out all responses David Miller
2011-02-20 22:28 ` Pablo Neira Ayuso
2011-02-20 22:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox