From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] tcp: undo_retrans counter fixes Date: Mon, 21 Feb 2011 11:31:46 -0800 (PST) Message-ID: <20110221.113146.193731519.davem@davemloft.net> References: <1297119424-19956-1-git-send-email-ycheng@google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, ilpo.jarvinen@helsinki.fi To: ycheng@google.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:51180 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754406Ab1BUTbK (ORCPT ); Mon, 21 Feb 2011 14:31:10 -0500 In-Reply-To: <1297119424-19956-1-git-send-email-ycheng@google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Yuchung Cheng Date: Mon, 7 Feb 2011 14:57:04 -0800 > Fix a bug that undo_retrans is incorrectly decremented when undo_marker is > not set or undo_retrans is already 0. This happens when sender receives > more DSACK ACKs than packets retransmitted during the current > undo phase. This may also happen when sender receives DSACK after > the undo operation is completed or cancelled. > > Fix another bug that undo_retrans is incorrectly incremented when > sender retransmits an skb and tcp_skb_pcount(skb) > 1 (TSO). This case > is rare but not impossible. > > Signed-off-by: Yuchung Cheng Applied and queued up for -stable, thanks.