From: David Miller <davem@davemloft.net>
To: mkl@pengutronix.de
Cc: netdev@vger.kernel.org, ben@fluff.org, daniel@caiaq.de
Subject: Re: [PATCH 0/9] ax88796: cleanups and convert to phylib and mdio_bitbang
Date: Tue, 22 Feb 2011 11:18:56 -0800 (PST) [thread overview]
Message-ID: <20110222.111856.102538007.davem@davemloft.net> (raw)
In-Reply-To: <1298293400-21570-1-git-send-email-mkl@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Mon, 21 Feb 2011 14:03:11 +0100
> this patch series fixes the phy-read/write problems of the ax88796
> (see http://www.spinics.net/lists/arm-kernel/msg98982.html).
>
> Patches 1-8 clean verious aspects of the driver. The 9th patch replaces the
> handcrafted mdio bitbang loop with the generic mdio_bitbang driver.
>
> This patch series has been tested on the Toradex colibri-320. With the patch
> mii-diag gives sound data:
>
> root@grabowski:~ mii-diag
> Using the default interface 'eth0'.
> Basic registers of MII PHY #16: 3100 782d 003b 1841 01e1 45e1 0003 0000.
> The autonegotiated capability is 01e0.
> The autonegotiated media type is 100baseTx-FD.
> Basic mode control register 0x3100: Auto-negotiation enabled.
> You have link beat, and everything is working OK.
> Your link partner advertised 45e1: Flow-control 100baseTx-FD 100baseTx 10baseT-FD 10baseT, w/ 802.3X flow control.
> End of basic transceiver information.
>
> please review and consider to appply.
Pulled into net-next-2.6, thanks.
BTW, we could remove the ARM MIPS etc. dependencies this driver has,
and replace it with HAS_IOMEM, as all the interfaces the driver uses
should be provided by every architecture.
next prev parent reply other threads:[~2011-02-22 19:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 13:03 [PATCH 0/9] ax88796: cleanups and convert to phylib and mdio_bitbang Marc Kleine-Budde
2011-02-21 13:03 ` [PATCH 1/9] ax88796: fix codingstyle and checkpatch warnings Marc Kleine-Budde
2011-02-21 13:03 ` [PATCH 2/9] ax88796: don't use magic ei_status to acces private data Marc Kleine-Budde
2011-02-21 13:03 ` [PATCH 3/9] ax88796: remove memset of " Marc Kleine-Budde
2011-02-21 13:03 ` [PATCH 4/9] ax88796: remove first_init parameter from ax_init_dev() Marc Kleine-Budde
2011-02-21 13:03 ` [PATCH 5/9] ax88796: use netdev_<LEVEL> instead of dev_<LEVEL> and pr_<LEVEL> Marc Kleine-Budde
2011-02-21 13:03 ` [PATCH 6/9] ax88796: remove platform_device member from struct ax_device Marc Kleine-Budde
2011-02-21 13:03 ` [PATCH 7/9] ax88796: make pointer to platform data const Marc Kleine-Budde
2011-02-21 13:03 ` [PATCH 8/9] ax88796: clean up probe and remove function Marc Kleine-Budde
2011-02-21 13:03 ` [PATCH 9/9] ax88796: use generic mdio_bitbang driver Marc Kleine-Budde
2011-02-22 19:18 ` David Miller [this message]
2011-02-22 20:19 ` [PATCH] ax88796: depend on HAS_IOMEM not on individual ARCHs Marc Kleine-Budde
2011-02-22 20:37 ` David Miller
2011-02-22 21:42 ` Marc Kleine-Budde
2011-02-22 22:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222.111856.102538007.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@fluff.org \
--cc=daniel@caiaq.de \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).