From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: eric.dumazet@gmail.com, kaber@trash.net,
Juliusz.Chroboczek@pps.jussieu.fr, linville@tuxdriver.com,
netdev@vger.kernel.org, andi@firstfloor.org
Subject: Re: [PATCH] net_sched: long word align struct qdisc_skb_cb data
Date: Wed, 23 Feb 2011 14:17:23 -0800 (PST) [thread overview]
Message-ID: <20110223.141723.39169376.davem@davemloft.net> (raw)
In-Reply-To: <20110223093001.28e1a8ef@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 23 Feb 2011 09:30:01 -0800
> On Wed, 23 Feb 2011 18:05:07 +0100
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> Le mercredi 23 février 2011 à 17:24 +0100, Patrick McHardy a écrit :
>> > Am 23.02.2011 16:14, schrieb Eric Dumazet:
>> > > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
>> > > index 16626a0..f40d32e 100644
>> > > --- a/include/net/sch_generic.h
>> > > +++ b/include/net/sch_generic.h
>> > > @@ -218,6 +218,7 @@ struct tcf_proto {
>> > >
>> > > struct qdisc_skb_cb {
>> > > unsigned int pkt_len;
>> > > + unsigned int sfb_classid;
>> > > char data[];
>> > > };
>> >
>> > This could be moved into a SFB specific cb, similar to what netem
>> > does.
>>
>> Hmm... well... I want to be sure no other sch will destroy my values.
>>
>> netem seems buggy then.
>>
>> Probably following patch is needed ?
>
> Yes, it was long word aligned when netem was written but
> we seem to have bit creep.
Applied to net-2.6, thanks!
next prev parent reply other threads:[~2011-02-23 22:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110221160306.GA9650@tuxdriver.com>
[not found] ` <1298308283.2849.5.camel@edumazet-laptop>
[not found] ` <1298390536.2861.9.camel@edumazet-laptop>
2011-02-23 15:14 ` [PATCH net-next-2.6 v3] net_sched: SFB flow scheduler Eric Dumazet
2011-02-23 15:43 ` Stephen Hemminger
2011-02-23 16:13 ` Eric Dumazet
2011-02-23 16:20 ` Patrick McHardy
2011-02-23 16:24 ` Patrick McHardy
2011-02-23 16:48 ` Eric Dumazet
2011-02-23 16:58 ` Patrick McHardy
2011-02-23 17:16 ` Eric Dumazet
2011-02-23 17:05 ` [PATCH] net_sched: long word align struct qdisc_skb_cb data Eric Dumazet
2011-02-23 17:30 ` Stephen Hemminger
2011-02-23 22:17 ` David Miller [this message]
2011-02-23 20:56 ` [PATCH net-next-2.6 v4] net_sched: SFB flow scheduler Eric Dumazet
2011-02-23 21:11 ` Stephen Hemminger
2011-02-23 21:28 ` Eric Dumazet
2011-02-23 21:30 ` David Miller
2011-02-23 22:06 ` David Miller
2011-02-24 5:40 ` Eric Dumazet
2011-02-24 6:51 ` Stephen Hemminger
2011-02-24 7:14 ` Eric Dumazet
2011-02-24 7:18 ` Eric Dumazet
2011-03-24 17:44 ` [PATCH iproute2] tc : " Eric Dumazet
2011-03-24 21:59 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223.141723.39169376.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Juliusz.Chroboczek@pps.jussieu.fr \
--cc=andi@firstfloor.org \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).