From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org,
bugme-daemon@bugzilla.kernel.org, gbillios@gmail.com
Subject: [PATCH] skge: don't mark carrier down at start
Date: Wed, 23 Feb 2011 16:44:49 -0800 [thread overview]
Message-ID: <20110223164449.2a5206b8@nehalam> (raw)
In-Reply-To: <20110223162156.17ab2bc5.akpm@linux-foundation.org>
The API for network devices has changed so that setting carrier
off at probe is no longer required. This should fix the IPv6 addrconf
issue.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/skge.c 2011-02-23 16:40:36.351045685 -0800
+++ b/drivers/net/skge.c 2011-02-23 16:40:48.315136410 -0800
@@ -3856,9 +3856,6 @@ static struct net_device *skge_devinit(s
memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port*8, ETH_ALEN);
memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
- /* device is off until link detection */
- netif_carrier_off(dev);
-
return dev;
}
next prev parent reply other threads:[~2011-02-24 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-29612-10286@https.bugzilla.kernel.org/>
2011-02-24 0:21 ` [Bugme-new] [Bug 29612] New: skge ipv6 doesn't work after boot Andrew Morton
2011-02-24 0:44 ` Stephen Hemminger [this message]
2011-02-24 0:52 ` [PATCH] skge: don't mark carrier down at start Andrew Morton
2011-02-25 6:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223164449.2a5206b8@nehalam \
--to=shemminger@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=gbillios@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).