* [PATCH] qla3xxx: add missing __iomem annotation
@ 2011-02-23 17:54 Stephen Hemminger
2011-02-23 21:47 ` Ron Mercer
2011-02-28 20:42 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2011-02-23 17:54 UTC (permalink / raw)
To: Ron Mercer, David Miller; +Cc: netdev
Add necessary annotations about pointer to io memory space
that is checked by sparse.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/qla3xxx.c 2011-02-23 09:42:44.363626866 -0800
+++ b/drivers/net/qla3xxx.c 2011-02-23 09:43:32.564194771 -0800
@@ -379,7 +379,7 @@ static void fm93c56a_select(struct ql3_a
{
struct ql3xxx_port_registers __iomem *port_regs =
qdev->mem_map_registers;
- u32 *spir = &port_regs->CommonRegs.serialPortInterfaceReg;
+ __iomem u32 *spir = &port_regs->CommonRegs.serialPortInterfaceReg;
qdev->eeprom_cmd_data = AUBURN_EEPROM_CS_1;
ql_write_nvram_reg(qdev, spir, ISP_NVRAM_MASK | qdev->eeprom_cmd_data);
@@ -398,7 +398,7 @@ static void fm93c56a_cmd(struct ql3_adap
u32 previousBit;
struct ql3xxx_port_registers __iomem *port_regs =
qdev->mem_map_registers;
- u32 *spir = &port_regs->CommonRegs.serialPortInterfaceReg;
+ __iomem u32 *spir = &port_regs->CommonRegs.serialPortInterfaceReg;
/* Clock in a zero, then do the start bit */
ql_write_nvram_reg(qdev, spir,
@@ -467,7 +467,7 @@ static void fm93c56a_deselect(struct ql3
{
struct ql3xxx_port_registers __iomem *port_regs =
qdev->mem_map_registers;
- u32 *spir = &port_regs->CommonRegs.serialPortInterfaceReg;
+ __iomem u32 *spir = &port_regs->CommonRegs.serialPortInterfaceReg;
qdev->eeprom_cmd_data = AUBURN_EEPROM_CS_0;
ql_write_nvram_reg(qdev, spir, ISP_NVRAM_MASK | qdev->eeprom_cmd_data);
@@ -483,7 +483,7 @@ static void fm93c56a_datain(struct ql3_a
u32 dataBit;
struct ql3xxx_port_registers __iomem *port_regs =
qdev->mem_map_registers;
- u32 *spir = &port_regs->CommonRegs.serialPortInterfaceReg;
+ __iomem u32 *spir = &port_regs->CommonRegs.serialPortInterfaceReg;
/* Read the data bits */
/* The first bit is a dummy. Clock right over it. */
@@ -3011,7 +3011,7 @@ static int ql_adapter_initialize(struct
u32 value;
struct ql3xxx_port_registers __iomem *port_regs =
qdev->mem_map_registers;
- u32 *spir = &port_regs->CommonRegs.serialPortInterfaceReg;
+ __iomem u32 *spir = &port_regs->CommonRegs.serialPortInterfaceReg;
struct ql3xxx_host_memory_registers __iomem *hmem_regs =
(void __iomem *)port_regs;
u32 delay = 10;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qla3xxx: add missing __iomem annotation
2011-02-23 17:54 [PATCH] qla3xxx: add missing __iomem annotation Stephen Hemminger
@ 2011-02-23 21:47 ` Ron Mercer
2011-02-28 20:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ron Mercer @ 2011-02-23 21:47 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David Miller, netdev@vger.kernel.org
On Wed, Feb 23, 2011 at 09:54:27AM -0800, Stephen Hemminger wrote:
> Add necessary annotations about pointer to io memory space
> that is checked by sparse.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
Thanks Stephen. Looks good.
Acked-by: Ron Mercer <ron.mercer@qlogic.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qla3xxx: add missing __iomem annotation
2011-02-23 17:54 [PATCH] qla3xxx: add missing __iomem annotation Stephen Hemminger
2011-02-23 21:47 ` Ron Mercer
@ 2011-02-28 20:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2011-02-28 20:42 UTC (permalink / raw)
To: shemminger; +Cc: ron.mercer, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 23 Feb 2011 09:54:27 -0800
> Add necessary annotations about pointer to io memory space
> that is checked by sparse.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-28 20:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-23 17:54 [PATCH] qla3xxx: add missing __iomem annotation Stephen Hemminger
2011-02-23 21:47 ` Ron Mercer
2011-02-28 20:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).