From: David Miller <davem@davemloft.net>
To: bcrl@kvack.org
Cc: netdev@vger.kernel.org
Subject: Re: via-rhine -- VT6105M and checksum offloading
Date: Thu, 24 Feb 2011 12:23:54 -0800 (PST) [thread overview]
Message-ID: <20110224.122354.193728354.davem@davemloft.net> (raw)
In-Reply-To: <20110224185805.GI30393@kvack.org>
From: Benjamin LaHaise <bcrl@kvack.org>
Date: Thu, 24 Feb 2011 13:58:05 -0500
> I've recently noticed that one of the embedded systems I'm using (the
> PCEngines ALIXes) is becoming CPU bound under heavy network traffic.
> Upon investigation, it looks like the VT6105M isn't actually using the
> hardware checksum offloading support of the hardware. Are there any
> known reasons why this isn't enabled (hardware bugs?)? I'll test enabling
> it in the driver, but I figured it would be worth asking if this path
> has been explored already. Cheers,
As far as I can tell it was never attempted. So it should work.
If you do that, while you're here, you can make rhine_rx() take
a "napi" arg and make this driver use netif_gso_receive() too.
Don't forget to set NETIF_F_GRO or similar in netdev->flags during
probe, and also hookup the necessary ethtool hooks.
next prev parent reply other threads:[~2011-02-24 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 18:58 via-rhine -- VT6105M and checksum offloading Benjamin LaHaise
2011-02-24 20:23 ` David Miller [this message]
2011-02-25 7:53 ` Roger Luethi
2011-02-25 18:35 ` Jan Ceuleers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224.122354.193728354.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcrl@kvack.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).