netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: therbert@google.com, eric.dumazet@gmail.com,
	shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH] xps-mq: Transmit Packet Steering for multiqueue
Date: Fri, 25 Feb 2011 23:09:39 -0800 (PST)	[thread overview]
Message-ID: <20110225.230939.112589117.davem@davemloft.net> (raw)
In-Reply-To: <1298312395.2608.65.camel@bwh-desktop>

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 21 Feb 2011 18:19:55 +0000

> On Wed, 2010-09-01 at 18:32 -0700, David Miller wrote:
>> 2) TX queue datastructures in the driver get reallocated using
>>    memory in that NUMA domain.
> 
> I've previously sent patches to add an ethtool API for NUMA control,
> which include the option to allocate on the same node where IRQs are
> handled.  However, there is currently no function to allocate
> DMA-coherent memory on a specified NUMA node (rather than the device's
> node).  This is likely to be beneficial for event rings and might be
> good for descriptor rings for some devices.  (The implementation I sent
> for sfc mistakenly switched it to allocating non-coherent memory, for
> which it *is* possible to specify the node.)

The thing to do is to work with someone like FUJITA Tomonori on this.

It's simply a matter of making new APIs that take the node specifier,
have the implementations either make use of or completely ignore the node,
and have the existing APIs pass in "-1" for the node or whatever the
CPP macro is for this :-)

  parent reply	other threads:[~2011-02-26  7:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-23  5:39 [PATCH] xps-mq: Transmit Packet Steering for multiqueue Tom Herbert
2010-08-23 17:09 ` Ben Hutchings
     [not found]   ` <AANLkTinST5zaS0NtBjrzyLbsg=w_EVsHE3DCDcrmQNc6@mail.gmail.com>
2010-08-23 17:50     ` Ben Hutchings
2010-08-23 17:59 ` Stephen Hemminger
2010-09-01 15:41   ` Tom Herbert
2010-09-01 15:54     ` Eric Dumazet
2010-09-01 16:24       ` Tom Herbert
2010-09-02  1:32         ` David Miller
2010-09-02  1:48           ` Stephen Hemminger
2010-09-02 16:00             ` Loke, Chetan
2010-09-02 19:52               ` Tom Herbert
2010-09-02 23:17                 ` Loke, Chetan
2010-09-02  1:56           ` Stephen Hemminger
2010-09-02  6:41             ` Greg Lindahl
2010-09-02 16:18             ` Loke, Chetan
2010-09-02 15:55           ` Loke, Chetan
2010-09-16 21:52           ` Ben Hutchings
2010-09-19 17:24             ` Michael S. Tsirkin
2010-09-20 12:44               ` [RFC][PATCH 1/3] IRQ: Add irq_get_numa_node() Ben Hutchings
2010-09-20 13:04                 ` Eric Dumazet
2010-09-20 12:45               ` [RFC][PATCH 2/3] ethtool: NUMA affinity control Ben Hutchings
2010-09-20 12:48               ` [RFC][PATCH 3/3] sfc: Add support for " Ben Hutchings
2011-02-21 18:19           ` [PATCH] xps-mq: Transmit Packet Steering for multiqueue Ben Hutchings
2011-02-21 19:31             ` Jeremy Eder
2011-02-26  7:09             ` David Miller [this message]
2010-09-01 16:09     ` David Miller
2010-08-24  4:31 ` Bill Fink
2010-08-24  4:37   ` Tom Herbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110225.230939.112589117.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).