From: Ajit Khaparde <ajit.khaparde@emulex.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [RFC] be2net: add rxhash support
Date: Sat, 26 Feb 2011 15:11:35 -0600 [thread overview]
Message-ID: <20110226211135.GA12549@akhaparde-VBox> (raw)
> From: Eric Dumazet [mailto:eric.dumazet@gmail.com]
> Sent: Saturday, February 26, 2011 4:31 AM
> To: Khaparde, Ajit
> Cc: netdev@vger.kernel.org
> Subject: Re: [RFC] be2net: add rxhash support
>
> Le vendredi 25 février 2011 à 15:35 -0600, Ajit Khaparde a écrit :
>
> > I asked that because, if a switch is part a of the configuration,
> > the ASIC can receive packets other than the tcp flow.
> >
> > And if hashing is enabled for IP packets, we can see this behavior.
> > The other values indicate that hashing has been enabled for IPv4
> packets.
>
> To make sure RSS (and rxhash) was OK, I added following debugging aid :
>
> diff --git a/include/net/sock.h b/include/net/sock.h
> index da0534d..e9b1180 100644
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
> @@ -688,6 +688,7 @@ static inline void sock_rps_save_rxhash(struct sock
> *sk, u32 rxhash)
> {
> #ifdef CONFIG_RPS
> if (unlikely(sk->sk_rxhash != rxhash)) {
> + pr_err("rxhash change from %x to %x\n", sk->sk_rxhash,
> rxhash);
> sock_rps_reset_flow(sk);
> sk->sk_rxhash = rxhash;
> }
>
>
> And got following traces :
>
> [ 201.170297] change rxhash from 0 to be0b5a87
> [ 232.607474] bonding: bond1: Setting eth3 as active slave.
> [ 232.607478] bonding: bond1: making interface eth3 the new active
> one.
> [ 232.710848] change rxhash from be0b5a87 to e56a3c1e
> [ 300.047500] bonding: bond1: Setting eth1 as active slave.
> [ 300.047504] bonding: bond1: making interface eth1 the new active
> one.
> [ 300.159162] change rxhash from e56a3c1e to be0b5a87
>
> The flip occured when I changed my active slave (bonding mode=1).
>
> eth1 is a bnx2 NIC, while eth3 a be2net one, so its OK to change the
> rxhash in this case
> (different firmware/algo)
>
> So as far as be2net is concerned, everything seems OK : all packets for
> a given flow get an unique RSS hash and can feed skb->rxhash
>
Fair enough. Thanks.
I guess a fresh patch with the ethtool support included will be ideal,
instead of the previous patch?
-Ajit
next reply other threads:[~2011-02-26 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 21:11 Ajit Khaparde [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-02-25 21:35 [RFC] be2net: add rxhash support Ajit Khaparde
2011-02-26 10:30 ` Eric Dumazet
2011-02-25 19:36 Ajit Khaparde
2011-02-25 19:45 ` Eric Dumazet
2011-02-25 17:44 Ajit Khaparde
2011-02-25 18:21 ` Eric Dumazet
2011-02-25 19:32 ` Eric Dumazet
[not found] <20110131232755.GA4691@akhaparde-VBox>
2011-02-01 23:42 ` [PATCH net-2.6 2/2] be2net: remove netif_stop_queue being called before register_netdev David Miller
2011-02-24 15:15 ` Eric Dumazet
2011-02-24 20:24 ` [RFC] be2net: add rxhash support Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110226211135.GA12549@akhaparde-VBox \
--to=ajit.khaparde@emulex.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).