From: David Miller <davem@davemloft.net>
To: jamie@jamieiles.com
Cc: netdev@vger.kernel.org, nicolas.ferre@atmel.com
Subject: Re: [PATCH] macb: don't use platform_set_drvdata() on a net_device
Date: Mon, 28 Feb 2011 12:22:33 -0800 (PST) [thread overview]
Message-ID: <20110228.122233.115936736.davem@davemloft.net> (raw)
In-Reply-To: <1298901925-16525-1-git-send-email-jamie@jamieiles.com>
From: Jamie Iles <jamie@jamieiles.com>
Date: Mon, 28 Feb 2011 14:05:25 +0000
> Commit 71d6429 (Driver core: convert platform_{get,set}_drvdata to
> static inline functions) now triggers a warning in the macb network
> driver:
>
> CC drivers/net/macb.o
> drivers/net/macb.c: In function ‘macb_mii_init’:
> drivers/net/macb.c:263: warning: passing argument 1 of ‘platform_set_drvdata’ from incompatible pointer type
> include/linux/platform_device.h:138: note: expected ‘struct platform_device *’ but argument is of type ‘struct net_device *’
>
> Use dev_set_drvdata() on the device embedded in the net_device instead.
>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Applied.
prev parent reply other threads:[~2011-02-28 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 14:05 [PATCH] macb: don't use platform_set_drvdata() on a net_device Jamie Iles
2011-02-28 20:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110228.122233.115936736.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jamie@jamieiles.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).