* [PATCH] sis900: use pci_dev->revision
@ 2011-02-22 20:29 Sergei Shtylyov
2011-02-28 20:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2011-02-22 20:29 UTC (permalink / raw)
To: netdev, venza
This driver uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't
converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65 (PCI: Change all
drivers to use pci_device->revision).
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree.
drivers/net/sis900.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/net/sis900.c
===================================================================
--- linux-2.6.orig/drivers/net/sis900.c
+++ linux-2.6/drivers/net/sis900.c
@@ -495,7 +495,7 @@ static int __devinit sis900_probe(struct
sis_priv->mii_info.reg_num_mask = 0x1f;
/* Get Mac address according to the chip revision */
- pci_read_config_byte(pci_dev, PCI_CLASS_REVISION, &(sis_priv->chipset_rev));
+ sis_priv->chipset_rev = pci_dev->revision;
if(netif_msg_probe(sis_priv))
printk(KERN_DEBUG "%s: detected revision %2.2x, "
"trying to get MAC address...\n",
@@ -532,7 +532,7 @@ static int __devinit sis900_probe(struct
/* save our host bridge revision */
dev = pci_get_device(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_630, NULL);
if (dev) {
- pci_read_config_byte(dev, PCI_CLASS_REVISION, &sis_priv->host_bridge_rev);
+ sis_priv->host_bridge_rev = dev->revision;
pci_dev_put(dev);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sis900: use pci_dev->revision
2011-02-22 20:29 [PATCH] sis900: use pci_dev->revision Sergei Shtylyov
@ 2011-02-28 20:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-02-28 20:29 UTC (permalink / raw)
To: sshtylyov; +Cc: netdev, venza
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Tue, 22 Feb 2011 23:29:01 +0300
> This driver uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't
> converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65 (PCI: Change all
> drivers to use pci_device->revision).
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-28 20:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-22 20:29 [PATCH] sis900: use pci_dev->revision Sergei Shtylyov
2011-02-28 20:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).