From: Jiri Pirko <jpirko@redhat.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, fubar@us.ibm.com, eric.dumazet@gmail.com,
nicolas.2p.debian@gmail.com, andy@greyhouse.net
Subject: Re: [patch net-next-2.6] bonding: remove skb_share_check in handle_frame
Date: Tue, 1 Mar 2011 10:29:07 +0100 [thread overview]
Message-ID: <20110301092907.GG2855@psychotron.redhat.com> (raw)
In-Reply-To: <20110301062250.GB2855@psychotron.redhat.com>
Unapplicable, sorry (wrong branch :(). Here's corrected patch:
Subject: [PATCH net-next-2.6 v2] bonding: remove skb_share_check in handle_frame
No need to do share check here.
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
---
drivers/net/bonding/bond_main.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 584f97b..367ea60 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1498,9 +1498,6 @@ static struct sk_buff *bond_handle_frame(struct sk_buff *skb)
struct net_device *slave_dev;
struct net_device *bond_dev;
- skb = skb_share_check(skb, GFP_ATOMIC);
- if (unlikely(!skb))
- return NULL;
slave_dev = skb->dev;
bond_dev = ACCESS_ONCE(slave_dev->master);
if (unlikely(!bond_dev))
--
1.7.3.4
next prev parent reply other threads:[~2011-03-01 9:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 6:22 [patch net-next-2.6] bonding: remove skb_share_check in handle_frame Jiri Pirko
2011-03-01 9:29 ` Jiri Pirko [this message]
2011-03-01 15:12 ` Changli Gao
2011-03-01 20:11 ` Nicolas de Pesloüan
2011-03-02 16:13 ` Changli Gao
2011-03-02 21:05 ` Nicolas de Pesloüan
2011-03-01 20:38 ` Andy Gospodarek
2011-03-02 10:03 ` Jiri Pirko
2011-03-02 12:29 ` Jiri Pirko
2011-03-02 20:47 ` Nicolas de Pesloüan
2011-03-02 21:12 ` Jiri Pirko
2011-03-02 21:54 ` Nicolas de Pesloüan
2011-03-03 6:14 ` Jiri Pirko
2011-03-03 8:37 ` Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301092907.GG2855@psychotron.redhat.com \
--to=jpirko@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).