From: David Miller <davem@davemloft.net>
To: mr.nuke.me@gmail.com
Cc: florian@openwrt.org, rl@hellgate.ch, netdev@vger.kernel.org
Subject: Re: [PATCH] via-rhine: do not abort due to invalid MAC address
Date: Wed, 02 Mar 2011 11:36:10 -0800 (PST) [thread overview]
Message-ID: <20110302.113610.71137356.davem@davemloft.net> (raw)
In-Reply-To: <4D6E883C.2000800@gmail.com>
From: "Alex G." <mr.nuke.me@gmail.com>
Date: Wed, 02 Mar 2011 20:11:08 +0200
> On 03/02/2011 08:01 PM, Florian Fainelli wrote:
>>
>> Why not generate a valid random ethernet address using random_ether_addr()
>> instead?
>
> That would confuse ifcfg-* scripts that specify HWETHER, and probably
> users as well. It might even stump udev.
If the ethernet address reported by the card is garbage, every single
ethernet driver that tried to handle this case uses a random ethernet
address.
There is no reason to choose a different strategy for this driver.
Also registering a network device with an invalid ethernet address can
cause all kinds of serious issues, let's say dhcp brings the device
up and emits DHCP requests with illegal MAC addresses in the header
because of this problem.
You therefore simply cannot leave crap in there.
next prev parent reply other threads:[~2011-03-02 19:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 16:32 [PATCH] via-rhine: do not abort due to invalid MAC address Roger Luethi
2011-03-02 18:01 ` Florian Fainelli
2011-03-02 18:11 ` Alex G.
2011-03-02 19:36 ` David Miller [this message]
2011-03-02 19:52 ` Roger Luethi
2011-03-02 19:49 ` Alex G.
2011-03-02 20:06 ` Alex G.
2011-03-03 21:42 ` David Miller
2011-03-03 21:51 ` Alex G.
2011-03-03 22:01 ` David Miller
2011-03-03 22:08 ` Alex G.
2011-03-09 21:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302.113610.71137356.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=mr.nuke.me@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rl@hellgate.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).