* [net-2.6 PATCH] net: dcbnl: check correct ops in dcbnl_ieee_set()
@ 2011-03-02 20:35 John Fastabend
2011-03-02 23:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: John Fastabend @ 2011-03-02 20:35 UTC (permalink / raw)
To: netdev; +Cc: john.r.fastabend, davem, shmulikr
The incorrect ops routine was being tested for in
DCB_ATTR_IEEE_PFC attributes. This patch corrects
it.
Currently, every driver implementing ieee_setets also
implements ieee_setpfc so this bug is not actualized
yet.
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
net/dcb/dcbnl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index d5074a5..c44348a 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -1193,7 +1193,7 @@ static int dcbnl_ieee_set(struct net_device *netdev, struct nlattr **tb,
goto err;
}
- if (ieee[DCB_ATTR_IEEE_PFC] && ops->ieee_setets) {
+ if (ieee[DCB_ATTR_IEEE_PFC] && ops->ieee_setpfc) {
struct ieee_pfc *pfc = nla_data(ieee[DCB_ATTR_IEEE_PFC]);
err = ops->ieee_setpfc(netdev, pfc);
if (err)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-2.6 PATCH] net: dcbnl: check correct ops in dcbnl_ieee_set()
2011-03-02 20:35 [net-2.6 PATCH] net: dcbnl: check correct ops in dcbnl_ieee_set() John Fastabend
@ 2011-03-02 23:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-03-02 23:05 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev, shmulikr
From: John Fastabend <john.r.fastabend@intel.com>
Date: Wed, 02 Mar 2011 12:35:33 -0800
> The incorrect ops routine was being tested for in
> DCB_ATTR_IEEE_PFC attributes. This patch corrects
> it.
>
> Currently, every driver implementing ieee_setets also
> implements ieee_setpfc so this bug is not actualized
> yet.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied, thanks John.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-02 23:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-02 20:35 [net-2.6 PATCH] net: dcbnl: check correct ops in dcbnl_ieee_set() John Fastabend
2011-03-02 23:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).