From: David Miller <davem@davemloft.net>
To: martinez.javier@gmail.com
Cc: mcarlson@broadcom.com, mchan@broadcom.com,
grant.likely@secretlab.ca, netdev@vger.kernel.org,
kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH 3/5] tg3: Enclose macro with complex values in parenthesis
Date: Wed, 02 Mar 2011 20:56:01 -0800 (PST) [thread overview]
Message-ID: <20110302.205601.71129255.davem@davemloft.net> (raw)
In-Reply-To: <1298999069-12740-3-git-send-email-martinez.javier@gmail.com>
From: Javier Martinez Canillas <martinez.javier@gmail.com>
Date: Tue, 1 Mar 2011 18:04:27 +0100
> Macros with complex values should be enclosed in parenthesis.
> Change accordingly.
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
This seems unnecessary, what problem do the current macro definitions
create?
next prev parent reply other threads:[~2011-03-03 4:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 17:04 [PATCH 1/5] tg3: use <linux/io.h> and <linux/uaccess.h> instead <asm/io.h> and <asm/uaccess.h> Javier Martinez Canillas
2011-03-01 17:04 ` [PATCH 1/5] tg3: use usleep_range not msleep for small sleeps Javier Martinez Canillas
2011-03-03 4:55 ` David Miller
2011-03-03 12:14 ` Javier Martinez Canillas
2011-03-01 17:04 ` [PATCH 3/5] tg3: Enclose macro with complex values in parenthesis Javier Martinez Canillas
2011-03-03 4:56 ` David Miller [this message]
2011-03-03 11:54 ` Javier Martinez Canillas
2011-03-01 17:04 ` [PATCH 4/5] tg3: Don't use IRQF_SAMPLE_RANDOM Javier Martinez Canillas
2011-03-01 17:04 ` [PATCH 5/5] tg3: Fix inline keyword usage Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302.205601.71129255.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=kernelnewbies@kernelnewbies.org \
--cc=martinez.javier@gmail.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).