netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jpirko@redhat.com>
To: linux-scsi@vger.kernel.org
Cc: devel@open-fcoe.org, robert.w.love@intel.com,
	netdev@vger.kernel.org, fubar@us.ibm.com, joe.eykholt@gmail.com
Subject: fcoe: correct checking for bonding
Date: Wed, 2 Mar 2011 07:05:35 +0100	[thread overview]
Message-ID: <20110302060535.GA2829@psychotron.redhat.com> (raw)

Check for bonding master and refuse to use that.

Signed-off-by: Jiri Pirko <jpirko@redhat.com>
---
 drivers/scsi/fcoe/fcoe.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 9f9600b..3becc6a 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -285,9 +285,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe,
 	}
 
 	/* Do not support for bonding device */
-	if ((netdev->priv_flags & IFF_MASTER_ALB) ||
-	    (netdev->priv_flags & IFF_SLAVE_INACTIVE) ||
-	    (netdev->priv_flags & IFF_MASTER_8023AD)) {
+	if (netdev->priv_flags & IFF_BONDING && netdev->flags & IFF_MASTER) {
 		FCOE_NETDEV_DBG(netdev, "Bonded interfaces not supported\n");
 		return -EOPNOTSUPP;
 	}
-- 
1.7.3.4


             reply	other threads:[~2011-03-02  6:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02  6:05 Jiri Pirko [this message]
2011-03-02  9:55 ` fcoe: correct checking for bonding Jiri Pirko
2011-03-03  1:09   ` Robert Love
2011-03-12 12:01     ` Jiri Pirko
2011-03-12 18:59       ` David Miller
2011-03-14 19:04         ` Robert Love
2011-03-14 19:22           ` Jiri Pirko
2011-03-14 20:20             ` David Miller
2011-03-14 20:53               ` James Bottomley
2011-03-14 21:04                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110302060535.GA2829@psychotron.redhat.com \
    --to=jpirko@redhat.com \
    --cc=devel@open-fcoe.org \
    --cc=fubar@us.ibm.com \
    --cc=joe.eykholt@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robert.w.love@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).