From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [BUG] VPN broken in net-next
Date: Wed, 2 Mar 2011 17:16:00 -0800 [thread overview]
Message-ID: <20110302171600.577a4548@nehalam> (raw)
In-Reply-To: <20110302.170346.13723622.davem@davemloft.net>
On Wed, 02 Mar 2011 17:03:46 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Wed, 2 Mar 2011 16:56:53 -0800
>
> > On Wed, 02 Mar 2011 16:50:09 -0800 (PST)
> > David Miller <davem@davemloft.net> wrote:
> >
> >> From: Stephen Hemminger <shemminger@vyatta.com>
> >> Date: Wed, 2 Mar 2011 16:46:37 -0800
> >>
> >> > The addresses (that matter) when VPN is up are:
> >>
> >> I really need to know what addresses interfaces have the time of the
> >> __ip_dev_find() call which, if I'm not mistaken, is before the VPN is
> >> up.
> >
> >
> > inet 127.0.0.1/8 scope host lo
> > inet 192.168.1.11/24 brd 192.168.1.255 scope global eth0
> > inet 192.168.100.1/24 brd 192.168.100.255 scope global virbr0
> > inet 192.168.99.1/24 brd 192.168.99.255 scope global virbr1
>
> I see nothing providing 10.0.whatever that __ip_dev_find() is being
> asked to resolve.
>
> I think we were allowing the route lookup pptp is trying to do at
> connect time erroneously, and it should elide the explicit source
> address specification in the flow.
>
The VPN connection comes up the problem is that no packets pass over
it successfully. The 10.X address is the other side of the VPN.
I tried this, but it didn't work.
--- a/drivers/net/pptp.c 2011-03-02 17:01:55.353313682 -0800
+++ b/drivers/net/pptp.c 2011-03-02 17:02:05.381146980 -0800
@@ -473,7 +473,6 @@ static int pptp_connect(struct socket *s
.nl_u = {
.ip4_u = {
.daddr = opt->dst_addr.sin_addr.s_addr,
- .saddr = opt->src_addr.sin_addr.s_addr,
.tos = RT_CONN_FLAGS(sk) } },
.proto = IPPROTO_GRE };
security_sk_classify_flow(sk, &fl);
prev parent reply other threads:[~2011-03-03 1:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 0:28 [BUG] VPN broken in net-next Stephen Hemminger
2011-03-03 0:41 ` Stephen Hemminger
2011-03-03 0:43 ` David Miller
2011-03-03 0:46 ` Stephen Hemminger
2011-03-03 0:50 ` David Miller
2011-03-03 0:54 ` David Miller
2011-03-03 12:41 ` Julian Anastasov
2011-03-03 13:09 ` Julian Anastasov
2011-03-03 17:32 ` Stephen Hemminger
2011-03-03 19:23 ` David Miller
2011-03-03 21:54 ` Stephen Hemminger
2011-03-04 8:39 ` Julian Anastasov
2011-03-23 4:56 ` David Miller
2011-03-23 9:05 ` Julian Anastasov
2011-03-23 15:24 ` Stephen Hemminger
2011-03-09 21:28 ` David Miller
2011-03-03 0:56 ` Stephen Hemminger
2011-03-03 1:03 ` David Miller
2011-03-03 1:16 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110302171600.577a4548@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).