From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] udp: udp_sendmsg() fix
Date: Thu, 03 Mar 2011 10:42:26 -0800 (PST) [thread overview]
Message-ID: <20110303.104226.71110201.davem@davemloft.net> (raw)
In-Reply-To: <1299172043.2983.142.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 03 Mar 2011 18:07:23 +0100
> [PATCH net-next-2.6] udp: udp_sendmsg() fix
>
> commit b23dd4fe42b455af (ipv4: Make output route lookup return rtable
> directly) introduced a regression in udp_sendmsg()
>
> If IP route lookup fails, we should not try to release an non existent
> route.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Ok, this works too.
My version NULL's out rt, so that if we had any changes in code paths
here it would be unlikely we'd reintroduce this bug.
I'm fine either way, although my version is in net-next-2.6 at the
moment :-)
next prev parent reply other threads:[~2011-03-03 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 16:28 [BUG net-next-2.6] dst_release() crash Eric Dumazet
2011-03-03 17:07 ` [PATCH net-next-2.6] udp: udp_sendmsg() fix Eric Dumazet
2011-03-03 18:42 ` David Miller [this message]
2011-03-03 19:02 ` Eric Dumazet
2011-03-03 18:38 ` [BUG net-next-2.6] dst_release() crash David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303.104226.71110201.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).