From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net_sched: reduce fifo qdisc size
Date: Thu, 03 Mar 2011 11:10:56 -0800 (PST) [thread overview]
Message-ID: <20110303.111056.183042516.davem@davemloft.net> (raw)
In-Reply-To: <1299158865.2983.98.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 03 Mar 2011 14:27:45 +0100
> Because of various alignements [SLUB / qdisc], we use 512 bytes of
> memory for one {p|b}fifo qdisc, instead of 256 bytes on 64bit arches and
> 192 bytes on 32bit ones.
>
> Move the "u32 limit" inside "struct Qdisc" (no impact on other qdiscs)
>
> Change qdisc_alloc(), first trying a regular allocation before an
> oversized one.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
It took me a moment to realize that leaving sch->padded uninitialized
in the sch==p case during allocation was legal ;-)
Applied, thanks!
prev parent reply other threads:[~2011-03-03 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 13:27 [PATCH net-next-2.6] net_sched: reduce fifo qdisc size Eric Dumazet
2011-03-03 19:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303.111056.183042516.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).