netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] mii: Convert printks to netdev_info
Date: Thu, 03 Mar 2011 12:32:25 -0800 (PST)	[thread overview]
Message-ID: <20110303.123225.242141985.davem@davemloft.net> (raw)
In-Reply-To: <1299184181.4338.152.camel@Joe-Laptop>

From: Joe Perches <joe@perches.com>
Date: Thu, 03 Mar 2011 12:29:41 -0800

> On Thu, 2011-03-03 at 12:21 -0800, David Miller wrote:
>> From: Joe Perches <joe@perches.com>
>> > Add a bit more data to the output.
>> > Convert string speeds to integer.
>> > Object size reduced a tiny bit.
>> > $ size drivers/net/mii.o*
>> >    text	   data	    bss	    dec	    hex	filename
>> >    4155	     56	   1000	   5211	   145b	drivers/net/mii.o.new
>> >    4184	     56	   1000	   5240	   1478	drivers/net/mii.o.old
>> > Signed-off-by: Joe Perches <joe@perches.com>
>> Applied.
> 
> David, please don't push this yet.

Reverted.

> This change is stuffed up somehow, it's
> a reversion of the tun.c change.

Oops.

> Let me send you a new/correct patch right now.

Ok.

  reply	other threads:[~2011-03-03 20:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02 17:18 [PATCH 1/3] tun: Convert logging messages to pr_<level> and tun_debug Joe Perches
2011-03-02 17:18 ` [PATCH 2/3] mii: Convert printks to netdev_info Joe Perches
2011-03-03 20:21   ` David Miller
2011-03-03 20:29     ` Joe Perches
2011-03-03 20:32       ` David Miller [this message]
2011-03-03 20:46         ` [PATCH 2/3 v2] " Joe Perches
2011-03-03 20:56           ` David Miller
2011-03-02 17:18 ` [PATCH 3/3] eql: Convert printks to pr_<level> and netdev_<level> Joe Perches
2011-03-03 20:21   ` David Miller
2011-03-03 20:59     ` David Miller
2011-03-03 21:08       ` [PATCH 3/3 v2] " Joe Perches
2011-03-03 21:30         ` David Miller
2011-03-03 20:21 ` [PATCH 1/3] tun: Convert logging messages to pr_<level> and tun_debug David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110303.123225.242141985.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).