From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: ja@ssi.bg, netdev@vger.kernel.org
Subject: Re: [BUG] VPN broken in net-next
Date: Thu, 3 Mar 2011 13:54:56 -0800 [thread overview]
Message-ID: <20110303135456.4fca2382@nehalam> (raw)
In-Reply-To: <20110303.112328.59677094.davem@davemloft.net>
On Thu, 03 Mar 2011 11:23:28 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Julian Anastasov <ja@ssi.bg>
> Date: Thu, 3 Mar 2011 15:09:22 +0200 (EET)
>
> > On Thu, 3 Mar 2011, Julian Anastasov wrote:
> >
> >> May be the problem is in inet_hash_insert(), it should
> >> hash ifa_local, not ifa_address. May be they are equal for
> >
> > ... and of course the new __ip_dev_find should use
> > ifa_local too.
>
> Thanks for looking into this Julian. I will look at the other
> cases you found later.
>
> Stephen, is this sufficient to fix your problem? I suspect it is
> not because fib_add_addr() adds prefixes with RTN_LOCAL to the
> local routing table too :-/
>
> I suspect that even if we need to handle prefixes, we can still use
> the hash for optimistic lookup, and fallback to a local table FIB
> inspection if that fails.
>
> --------------------
> ipv4: Fix __ip_dev_find() to use ifa_local instead of ifa_address.
>
> Reported-by: Stephen Hemminger <shemminger@vyatta.com>
> Reported-by: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
VPN works now with this patch on net-next.
next prev parent reply other threads:[~2011-03-03 21:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 0:28 [BUG] VPN broken in net-next Stephen Hemminger
2011-03-03 0:41 ` Stephen Hemminger
2011-03-03 0:43 ` David Miller
2011-03-03 0:46 ` Stephen Hemminger
2011-03-03 0:50 ` David Miller
2011-03-03 0:54 ` David Miller
2011-03-03 12:41 ` Julian Anastasov
2011-03-03 13:09 ` Julian Anastasov
2011-03-03 17:32 ` Stephen Hemminger
2011-03-03 19:23 ` David Miller
2011-03-03 21:54 ` Stephen Hemminger [this message]
2011-03-04 8:39 ` Julian Anastasov
2011-03-23 4:56 ` David Miller
2011-03-23 9:05 ` Julian Anastasov
2011-03-23 15:24 ` Stephen Hemminger
2011-03-09 21:28 ` David Miller
2011-03-03 0:56 ` Stephen Hemminger
2011-03-03 1:03 ` David Miller
2011-03-03 1:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303135456.4fca2382@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).