From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: rdunlap@xenotime.net, j223yang@asset.uwaterloo.ca,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch] ariadne: fix possible null dereference
Date: Sun, 06 Mar 2011 18:07:58 -0800 (PST) [thread overview]
Message-ID: <20110306.180758.226774711.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTiko+HzYMnGEtvb63Fzi2eNge6_iWPmk7EfjFma7@mail.gmail.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sun, 6 Mar 2011 21:00:13 +0100
> On Sun, Mar 6, 2011 at 20:11, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> On Sun, 6 Mar 2011 02:08:32 -0500 j223yang@asset.uwaterloo.ca wrote:
>>
>>> Hi Randy,
>>> I have tested my patch, and it is ok now.
>>> Could you please try patching again? Sorry for previous trouble.
>>> Thank you!
>>
>> Acked-by: Randy Dunlap <rdunlap@xenotime.net>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
People really don't actually read patches, I think.
Show me how dev can even be NULL here, it simply can't.
So the correct fix is to remove the dev==NULL check altogether.
next prev parent reply other threads:[~2011-03-07 2:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 7:08 [Patch] ariadne: fix possible null dereference j223yang
2011-03-06 19:11 ` Randy Dunlap
2011-03-06 20:00 ` Geert Uytterhoeven
2011-03-07 2:07 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-03-04 17:46 j223yang
2011-03-04 18:31 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110306.180758.226774711.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=j223yang@asset.uwaterloo.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).