From: David Miller <davem@davemloft.net>
To: eli@dev.mellanox.co.il
Cc: roland@purestorage.com, netdev@vger.kernel.org
Subject: Re: [PATCH 13/17] mlx4: Add blue flame support for kernel consumers
Date: Mon, 07 Mar 2011 14:09:12 -0800 (PST) [thread overview]
Message-ID: <20110307.140912.35052431.davem@davemloft.net> (raw)
In-Reply-To: <20110307215803.GB19540@mtldesk30>
From: Eli Cohen <eli@dev.mellanox.co.il>
Date: Mon, 7 Mar 2011 23:58:03 +0200
> On Mon, Mar 07, 2011 at 01:49:31PM -0800, David Miller wrote:
>>
>> It's a performance optimization, if you don't get write combining you'll
>> get more strict ordering, rather than less.
>>
>> It cannot cause problem.
>
> I agree, but the function could still fail and the caller's logic
> could attempt to call ioreamp or take other action. For example, in
> the case of blue flame, it is better performance-wise to avoid using
> this feature if write combining is not available.
It could, but the less complicated the interfaces the better.
next prev parent reply other threads:[~2011-03-07 22:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CFE9BFE80FFE4D4892AA5D31387E310F02F3ED@mtldag01.mtl.com>
2011-03-07 21:36 ` FW: [PATCH 13/17] mlx4: Add blue flame support for kernel consumers Eli Cohen
2011-03-07 21:40 ` David Miller
2011-03-07 21:48 ` Eli Cohen
2011-03-07 21:49 ` David Miller
2011-03-07 21:50 ` David Miller
2011-03-07 21:58 ` Eli Cohen
2011-03-07 22:09 ` David Miller [this message]
2011-03-07 10:17 Yevgeny Petrilin
2011-03-07 21:07 ` Roland Dreier
2011-03-07 21:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307.140912.35052431.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eli@dev.mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).