From: David Miller <davem@davemloft.net>
To: nils.carlson@ericsson.com
Cc: fubar@us.ibm.com, andy@greyhouse.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] bonding 802.3ad: Fix the state machine locking v2
Date: Mon, 07 Mar 2011 16:03:15 -0800 (PST) [thread overview]
Message-ID: <20110307.160315.13736027.davem@davemloft.net> (raw)
In-Reply-To: <1299226152-23578-1-git-send-email-nils.carlson@ericsson.com>
From: Nils Carlson <nils.carlson@ericsson.com>
Date: Fri, 4 Mar 2011 09:09:11 +0100
> Changes since v1:
> * Clarify an unclear comment
> * Move a (possible) name change to a separate patch
>
> The ad_rx_machine, ad_periodic_machine and ad_port_selection_logic
> functions all inspect and alter common fields within the port structure.
> Previous to this patch, only the ad_rx_machines were mutexed, and the
> periodic and port_selection could run unmutexed against an ad_rx_machine
> trigged by an arriving LACPDU.
>
> This patch remedies the situation by protecting all the state machines
> from concurrency. This is accomplished by locking around all the state
> machines for a given port, which are executed at regular intervals; and
> the ad_rx_machine when handling an incoming LACPDU.
>
> Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Applied.
prev parent reply other threads:[~2011-03-08 0:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 8:09 [PATCH 1/2] bonding 802.3ad: Fix the state machine locking v2 Nils Carlson
2011-03-04 8:09 ` [PATCH 2/2] bonding 802.3ad: Rename rx_machine_lock to state_machine_lock Nils Carlson
2011-03-08 0:03 ` David Miller
2011-03-08 0:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307.160315.13736027.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nils.carlson@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox