From: Jiri Pirko <jpirko@redhat.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
Jay Vosburgh <fubar@us.ibm.com>,
netdev@vger.kernel.org
Subject: Re: [V2 Patch] bonding: move procfs code into bond_procfs.c
Date: Mon, 7 Mar 2011 08:49:50 +0100 [thread overview]
Message-ID: <20110307074949.GA2792@psychotron.redhat.com> (raw)
In-Reply-To: <1299484726-29905-1-git-send-email-amwang@redhat.com>
Mon, Mar 07, 2011 at 08:58:46AM CET, amwang@redhat.com wrote:
>V2: Move #ifdef CONFIG_PROC_FS into bonding.h, as suggested by David.
>
>bond_main.c is bloating, separate the procfs code out,
>move them to bond_procfs.c
>
>Signed-off-by: WANG Cong <amwang@redhat.com>
>
>---
> drivers/net/bonding/Makefile | 3 +
> drivers/net/bonding/bond_main.c | 302 +------------------------------------
> drivers/net/bonding/bond_procfs.c | 276 +++++++++++++++++++++++++++++++++
> drivers/net/bonding/bonding.h | 26 +++
> 4 files changed, 307 insertions(+), 300 deletions(-)
>
Looking good to me
Reviewed-by: Jiri Pirko <jpirko@redhat.com>
next prev parent reply other threads:[~2011-03-07 7:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 7:58 [V2 Patch] bonding: move procfs code into bond_procfs.c Amerigo Wang
2011-03-07 7:49 ` Jiri Pirko [this message]
2011-03-07 16:17 ` Andy Gospodarek
2011-03-09 21:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307074949.GA2792@psychotron.redhat.com \
--to=jpirko@redhat.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).