From: David Miller <davem@davemloft.net>
To: ja@ssi.bg
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: Cache source address in nexthop entries.
Date: Tue, 08 Mar 2011 10:38:01 -0800 (PST) [thread overview]
Message-ID: <20110308.103801.193702247.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1103081030090.1529@ja.ssi.bg>
From: Julian Anastasov <ja@ssi.bg>
Date: Tue, 8 Mar 2011 11:57:38 +0200 (EET)
> It means, even if there are addresses on the
> concerned device it does not mean the routes on this device
> are required to use prefsrc from this device. We must
> restrict the scope according to the provided for the
> route: cfg->fc_scope.
Simple to fix, I'll remember the fc_scope value in the nexthop
and use that in the address selection call.
> As the addresses have nothing to do with the link
> state, I don't think it is correct to call fib_update_nh_saddrs
> for DEV events.
fib_update_nh_saddrs() gets called for "DEV" events since those
are what are emitted when addresses are addded and removed.
next prev parent reply other threads:[~2011-03-08 18:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 4:58 [PATCH] ipv4: Cache source address in nexthop entries David Miller
2011-03-08 9:57 ` Julian Anastasov
2011-03-08 18:38 ` David Miller [this message]
2011-03-08 19:03 ` David Miller
2011-03-15 10:00 ` Julian Anastasov
2011-03-15 23:02 ` David Miller
2011-03-09 0:49 ` Julian Anastasov
2011-03-09 21:08 ` David Miller
2011-03-09 23:32 ` Julian Anastasov
2011-03-09 23:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308.103801.193702247.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).