netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: remi@remlab.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/8] Phonet: fix NULL-deref in a8059512b120362b15424f152b2548fe8b11bd0c
Date: Tue, 08 Mar 2011 13:34:21 -0800 (PST)	[thread overview]
Message-ID: <20110308.133421.179935481.davem@davemloft.net> (raw)
In-Reply-To: <201103082330.31652.remi@remlab.net>

From: "Rémi Denis-Courmont" <remi@remlab.net>
Date: Tue, 8 Mar 2011 23:30:31 +0200

> Le mardi 8 mars 2011 23:09:26 David Miller, vous avez écrit :
>> From: "Rémi Denis-Courmont" <remi@remlab.net>
>> Date: Tue, 8 Mar 2011 22:59:41 +0200
>> 
>> > I just wish you'd been as strict back then.
>> 
>> The only thing worse that putting crappy code into the tree is having
>> patches rot in patchwork because the maintainer isn't responsive at
>> reviewing things.
> 
> Patch submitted:
> Date: Mon, 27 Sep 2010 10:37:59 +0530
> 
> Patch merged:
> Date: Mon, 27 Sep 2010 21:50:59 -0700
> 
> So the patches had been "rotting" for 0 days 23:13:00. Come on.

I gave you nearly a full day.

If I do my daily email scan twice, and see the same patch on both
occaisions without a review I am very likely to merge the thing
or poke the maintainer.


  reply	other threads:[~2011-03-08 21:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08 13:56 [RFCv3] [PATCH 0/8] net-next: Phonet fixes and cleanup Rémi Denis-Courmont
2011-03-08 13:56 ` [PATCH 1/8] Phonet: fix NULL-deref in a8059512b120362b15424f152b2548fe8b11bd0c Rémi Denis-Courmont
2011-03-08 19:29   ` David Miller
2011-03-08 20:59     ` Rémi Denis-Courmont
2011-03-08 21:09       ` David Miller
2011-03-08 21:30         ` Rémi Denis-Courmont
2011-03-08 21:34           ` David Miller [this message]
2011-03-08 13:57 ` [PATCH 2/8] Phonet: return an error when skb TX fails Rémi Denis-Courmont
2011-03-08 13:57 ` [PATCH 3/8] Phonet: correct pipe backlog callback return values Rémi Denis-Courmont
2011-03-08 13:57 ` [PATCH 4/8] Phonet: factor common code to send control messages Rémi Denis-Courmont
2011-03-08 13:57 ` [PATCH 5/8] Phonet: allocate sock from accept syscall rather than soft IRQ Rémi Denis-Courmont
2011-03-08 13:57 ` [PATCH 6/8] Phonet: provide pipe socket option to retrieve the pipe identifier Rémi Denis-Courmont
2011-03-08 13:57 ` [PATCH 7/8] Phonet: support active connection without pipe controller on modem Rémi Denis-Courmont
2011-03-08 13:57 ` [PATCH 8/8] Phonet: kill the ST-Ericsson pipe controller Kconfig Rémi Denis-Courmont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110308.133421.179935481.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=remi@remlab.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).