From: David Miller <davem@davemloft.net>
To: roland@kernel.org
Cc: or.gerlitz@gmail.com, yevgenyp@mellanox.co.il,
netdev@vger.kernel.org, vlad@mellanox.co.il, nirmu@mellanox.com,
alekseys@mellanox.com
Subject: Re: [PATCH 11/17] mlx4_en: Enabling new steering
Date: Tue, 08 Mar 2011 14:26:49 -0800 (PST) [thread overview]
Message-ID: <20110308.142649.183050876.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTim8XDT5YKJc4wroyEDJc1X+xZOFL9y_090F5eLr@mail.gmail.com>
From: Roland Dreier <roland@kernel.org>
Date: Tue, 8 Mar 2011 13:30:25 -0800
> On Tue, Mar 8, 2011 at 1:10 PM, Or Gerlitz <or.gerlitz@gmail.com> wrote:
>>> + if (mdev->dev->caps.vep_mc_steering && ibqp->qp_type == IB_QPT_RAW_ETHERTYPE) {
>>
>> Guys,
>>
>> Didn't you want to refer here to the "raw ethernet QP" which is typed
>> to IB_QPT_RAW_PACKET by the series posted on December last year, see
>> http://marc.info/?l=linux-rdma&m=129162076818154 --
>> IB_QPT_RAW_ETHERTYPE is a rename of IB's IB_QPT_RAW_ETY done by
>> commit a2ebf07ae53e65bd073f96877e4818f2e89271ae
>
> Good catch. I think the drivers/infiniband part of this patch should
> just be dropped -- we don't have any raw QP support of any kind, right?
Once this is all sorted out, please someone respin this entire patch
set.
Thanks.
prev parent reply other threads:[~2011-03-08 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 10:17 [PATCH 11/17] mlx4_en: Enabling new steering Yevgeny Petrilin
2011-03-08 21:10 ` Or Gerlitz
2011-03-08 21:30 ` Roland Dreier
2011-03-08 22:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308.142649.183050876.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alekseys@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nirmu@mellanox.com \
--cc=or.gerlitz@gmail.com \
--cc=roland@kernel.org \
--cc=vlad@mellanox.co.il \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).