From: Adam Majer <adamm@zombino.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>,
"Alexey Kuznetsov" <kuznet@ms2.inr.ac.ru>,
"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
"James Morris" <jmorris@namei.org>,
"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
"Patrick McHardy" <kaber@trash.net>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
"Andy Gospodarek" <andy@greyhouse.net>,
"Jay Vosburgh" <fubar@us.ibm.com>
Subject: Re: [PATCH] bridge: control carrier based on ports online
Date: Mon, 7 Mar 2011 19:08:47 -0600 [thread overview]
Message-ID: <20110308010847.GA2316@mira.lan.galacticasoftware.com> (raw)
In-Reply-To: <20110307103406.27330529@nehalam>
On Mon, Mar 07, 2011 at 10:34:06AM -0800, Stephen Hemminger wrote:
> This makes the bridge device behave like a physical device.
> In earlier releases the bridge always asserted carrier. This
> changes the behavior so that bridge device carrier is on only
> if one or more ports are in the forwarding state. This
> should help IPv6 autoconfiguration, DHCP, and routing daemons.
Yes, your patch does fix issues with IPv6 autoconfiguration in bridged
networks completely. I've just tested it with and without STP. IPv4
DHCP continues to function correctly. It is definitely much cleaner
solution than my hack.
IPv6 autoconfiguration code already checks if NETDEV_CHANGE or
NETDEV_UP represent a device that is ready to transmit data before
attempting to configure the interface. No additional changes required
there. This patch should also fix duplicate address detection of
linklocal address on bridged interfaces that I believe was also broken
prior to this patch.
If you want, you can add
Tested-By: Adam Majer <adamm@zombino.com>
Cheers,
- Adam
next prev parent reply other threads:[~2011-03-08 1:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 5:18 [PATCH 1/2] Issue NETDEV_CHANGE notification when bridge changes state Adam Majer
2011-03-06 5:20 ` [PATCH 2/2] Retry autoconfiguration on interface after NETDEV_CHANGE notification Adam Majer
2011-03-06 5:31 ` [PATCH 1/2] Issue NETDEV_CHANGE notification when bridge changes state Adam Majer
2011-03-06 6:43 ` Stephen Hemminger
2011-03-06 8:03 ` Adam Majer
2011-03-06 17:45 ` Stephen Hemminger
2011-03-07 0:25 ` Adam Majer
2011-03-07 6:41 ` Stephen Hemminger
2011-03-07 7:44 ` Nicolas de Pesloüan
2011-03-07 18:34 ` [PATCH] bridge: control carrier based on ports online Stephen Hemminger
2011-03-07 20:48 ` Nicolas de Pesloüan
2011-03-07 21:44 ` Stephen Hemminger
2011-03-07 21:51 ` Nicolas de Pesloüan
2011-03-08 1:08 ` Adam Majer [this message]
2011-03-14 21:29 ` David Miller
2011-03-06 18:01 ` [PATCH 1/2] Issue NETDEV_CHANGE notification when bridge changes state Jan Ceuleers
2011-03-09 15:09 ` Américo Wang
2011-03-09 16:44 ` Adam Majer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308010847.GA2316@mira.lan.galacticasoftware.com \
--to=adamm@zombino.com \
--cc=andy@greyhouse.net \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@gmail.com \
--cc=pekkas@netcore.fi \
--cc=shemminger@vyatta.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).