From: David Miller <davem@davemloft.net>
To: ja@ssi.bg
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: Cache source address in nexthop entries.
Date: Wed, 09 Mar 2011 13:08:17 -0800 (PST) [thread overview]
Message-ID: <20110309.130817.115943793.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1103090157400.2880@ja.ssi.bg>
From: Julian Anastasov <ja@ssi.bg>
Date: Wed, 9 Mar 2011 02:49:49 +0200 (EET)
> But we still need to propagate the address events
> to nexthops on all devices. Even if it is slow, I see it in
> this way (not tested):
Ok, I think it is even more involved than what you propose.
We have to potentially re-run inet_select_addr() on all nexthops, even
those pointing to devices other than the one being modified, because
when an interface loses it's last IP address we have to look for a
source address to use on other active interfaces.
Probably it makes sense to recompute this at use time instead of
walking all of this stuff at every event.
So device address operations increment a generation ID and
FIB_RES_PREFSRC() checks that ID against one stored in the nexthop.
next prev parent reply other threads:[~2011-03-09 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 4:58 [PATCH] ipv4: Cache source address in nexthop entries David Miller
2011-03-08 9:57 ` Julian Anastasov
2011-03-08 18:38 ` David Miller
2011-03-08 19:03 ` David Miller
2011-03-15 10:00 ` Julian Anastasov
2011-03-15 23:02 ` David Miller
2011-03-09 0:49 ` Julian Anastasov
2011-03-09 21:08 ` David Miller [this message]
2011-03-09 23:32 ` Julian Anastasov
2011-03-09 23:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309.130817.115943793.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).