From: David Miller <davem@davemloft.net>
To: mr.nuke.me@gmail.com
Cc: netdev@vger.kernel.org, rl@hellgate.ch, florian@openwrt.org
Subject: Re: [PATCH] via-rhine: Work around invalid MAC address error
Date: Wed, 09 Mar 2011 13:44:36 -0800 (PST) [thread overview]
Message-ID: <20110309.134436.28819615.davem@davemloft.net> (raw)
In-Reply-To: <4D77F253.5010908@gmail.com>
From: "Alex G." <mr.nuke.me@gmail.com>
Date: Wed, 09 Mar 2011 23:34:11 +0200
> via-rhine drops out of the init code if the hardware provides an invalid
> MAC address. Roger Luethi has had several reports of Rhine NICs doing just
> that. The hardware still works, though; assigning a random MAC address
> allows the NIC to be used as usual. Tested as a standalone interface,
> as carrier for ppp, and as bonding slave.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
>
> diff --git a/drivers/net/via-rhine.c.orig b/drivers/net/via-rhine.c
> index 4930f9d..4c1b9e7 100644
> --- a/drivers/net/via-rhine.c.orig
> +++ b/drivers/net/via-rhine.c
This is getting rediculious:
davem@sunset:~/src/GIT/net-2.6$ git apply --check --whitespace=error-all via-rhine-Work-around-invalid-MAC-address-error.patch
error: drivers/net/via-rhine.c.orig: No such file or directory
davem@sunset:~/src/GIT/net-2.6$
davem@sunset:~/src/GIT/net-2.6$ git am --signoff via-rhine-Work-around-invalid-MAC-address-error.patch
Applying: via-rhine: Work around invalid MAC address error
error: drivers/net/via-rhine.c.orig: does not exist in index
Patch failed at 0001 via-rhine: Work around invalid MAC address error
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
You have new mail in /var/mail/davem
davem@sunset:~/src/GIT/net-2.6$ git am --abort
Sorry.
I'm going to ignore you're postings for a day or two, I've already
invested an enormous amount of time and energy into getting you to
submit patches which are properly formed and actually get accepted by
the tools that we all use. Nobody else has these kinds of problems
and can submit properly formed patches.
I would strongly suggest that you try to email the patch to yourself,
save the email into a file, and feed it to "git am" on a fresh tree,
making sure that when then looking at what the resulting commit looks
like.
next prev parent reply other threads:[~2011-03-09 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 21:34 [PATCH] via-rhine: Work around invalid MAC address error Alex G.
2011-03-09 21:44 ` David Miller [this message]
2011-03-10 2:04 ` Alex G.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309.134436.28819615.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=mr.nuke.me@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rl@hellgate.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).