* [PATCH] pktgen: fix errata in show results
@ 2011-03-07 9:09 Daniel Turull
2011-03-07 9:19 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Turull @ 2011-03-07 9:09 UTC (permalink / raw)
To: netdev; +Cc: 이종원, Robert Olsson
The units in show_results in pktgen were not correct.
The results are in usec but it was displayed nsec.
Reported-by: Jong-won Lee <ljw@handong.edu>
Signed-off-by: Daniel Turull <daniel.turull@gmail.com>
---
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index d73b77a..f0aec6c 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3271,7 +3271,7 @@ static void show_results(struct pktgen_dev
*pkt_dev, int nr_frags)
pkt_dev->started_at);
ktime_t idle = ns_to_ktime(pkt_dev->idle_acc);
- p += sprintf(p, "OK: %llu(c%llu+d%llu) nsec, %llu (%dbyte,%dfrags)\n",
+ p += sprintf(p, "OK: %llu(c%llu+d%llu) usec, %llu (%dbyte,%dfrags)\n",
(unsigned long long)ktime_to_us(elapsed),
(unsigned long long)ktime_to_us(ktime_sub(elapsed, idle)),
(unsigned long long)ktime_to_us(idle),
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pktgen: fix errata in show results
2011-03-07 9:09 [PATCH] pktgen: fix errata in show results Daniel Turull
@ 2011-03-07 9:19 ` David Miller
2011-03-07 9:44 ` Daniel Turull
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2011-03-07 9:19 UTC (permalink / raw)
To: daniel.turull; +Cc: netdev, ljw, robert
From: Daniel Turull <daniel.turull@gmail.com>
Date: Mon, 07 Mar 2011 10:09:43 +0100
> The units in show_results in pktgen were not correct.
> The results are in usec but it was displayed nsec.
>
> Reported-by: Jong-won Lee <ljw@handong.edu>
> Signed-off-by: Daniel Turull <daniel.turull@gmail.com>
> ---
Your email client corrupted the patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pktgen: fix errata in show results
2011-03-07 9:19 ` David Miller
@ 2011-03-07 9:44 ` Daniel Turull
2011-03-09 22:11 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Turull @ 2011-03-07 9:44 UTC (permalink / raw)
To: David Miller; +Cc: netdev, ljw, robert, Daniel Turull
The units in show_results in pktgen were not correct.
The results are in usec but it was displayed nsec.
Reported-by: Jong-won Lee <ljw@handong.edu>
Signed-off-by: Daniel Turull <daniel.turull@gmail.com>
---
Here it is the new version.
Sorry for the previous mail.
Daniel
---
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index d73b77a..f0aec6c 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3271,7 +3271,7 @@ static void show_results(struct pktgen_dev *pkt_dev, int nr_frags)
pkt_dev->started_at);
ktime_t idle = ns_to_ktime(pkt_dev->idle_acc);
- p += sprintf(p, "OK: %llu(c%llu+d%llu) nsec, %llu (%dbyte,%dfrags)\n",
+ p += sprintf(p, "OK: %llu(c%llu+d%llu) usec, %llu (%dbyte,%dfrags)\n",
(unsigned long long)ktime_to_us(elapsed),
(unsigned long long)ktime_to_us(ktime_sub(elapsed, idle)),
(unsigned long long)ktime_to_us(idle),
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pktgen: fix errata in show results
2011-03-07 9:44 ` Daniel Turull
@ 2011-03-09 22:11 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2011-03-09 22:11 UTC (permalink / raw)
To: daniel.turull; +Cc: netdev, ljw, robert
From: Daniel Turull <daniel.turull@gmail.com>
Date: Mon, 07 Mar 2011 10:44:40 +0100
> The units in show_results in pktgen were not correct.
> The results are in usec but it was displayed nsec.
>
> Reported-by: Jong-won Lee <ljw@handong.edu>
> Signed-off-by: Daniel Turull <daniel.turull@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-09 22:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-07 9:09 [PATCH] pktgen: fix errata in show results Daniel Turull
2011-03-07 9:19 ` David Miller
2011-03-07 9:44 ` Daniel Turull
2011-03-09 22:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).