From: David Miller <davem@davemloft.net>
To: randy.dunlap@oracle.com
Cc: netdev@bof.de, shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.38-rc8 build failure] net: bridge builtin vs. ipv6 modular
Date: Thu, 10 Mar 2011 13:49:08 -0800 (PST) [thread overview]
Message-ID: <20110310.134908.226783215.davem@davemloft.net> (raw)
In-Reply-To: <20110310132801.4a919df2.randy.dunlap@oracle.com>
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Thu, 10 Mar 2011 13:28:01 -0800
> This can be fixed in either of 2 ways. One way is to require that the
> bridge code building depend on how the IPV6 code is built (builtin or modular);
> the other way is to handle the kconfig variations in net/bridge/br_multicast.c --
> but this loses some functionality if IPV6=m and BRIDGE=y.
>
> I prefer the Kconfig patch over the br_multicast.c patch.
> Both patches are below for consideration.
I definitely prefer the Kconfig variant, although it's unfortunate that we
have a stateful dependency in the bridging multicast code.
IPV4 seems to let us use INADDR_ANY as the source address in the multicast
query, but IPV6 does not allow this (as per RFC 2710).
Anyways, I've applied the Kconfig patch, thanks Randy!
prev parent reply other threads:[~2011-03-10 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 10:19 2.6.38-rc8 build failure - bridge vs. ipv6 Patrick Schaaf
2011-03-10 21:28 ` [PATCH 2.6.38-rc8 build failure] net: bridge builtin vs. ipv6 modular Randy Dunlap
2011-03-10 21:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310.134908.226783215.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@bof.de \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).