From: David Miller <davem@davemloft.net>
To: j223yang@asset.uwaterloo.ca
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] ariadne: remove redundant NULL check
Date: Thu, 10 Mar 2011 14:40:34 -0800 (PST) [thread overview]
Message-ID: <20110310.144034.39174581.davem@davemloft.net> (raw)
In-Reply-To: <20110310.143942.183042624.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 10 Mar 2011 14:39:42 -0800 (PST)
> From: j223yang@asset.uwaterloo.ca
> Date: Thu, 10 Mar 2011 17:36:37 -0500
>
>> Simply remove redundant 'dev' NULL check.
>> Source code uses spaces instead of TAB, except 'printk' and 'return' lines.
>>
>>
>> Signed-off-by: Jinqiu Yang <crindy646@gmail.com>
>
> Patch is still corrupted by your email client, the same way as before.
Sorry, I apologize, this is not your fault.
This is one of those terrible old drivers that have bad coding
style.
I'll apply this patch, thank you.
next prev parent reply other threads:[~2011-03-10 22:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 22:36 [patch] ariadne: remove redundant NULL check j223yang
2011-03-10 22:39 ` David Miller
2011-03-10 22:40 ` David Miller [this message]
2011-03-11 9:57 ` Nicolas Kaiser
-- strict thread matches above, loose matches on Subject: below --
2011-03-10 17:20 [Patch]ariadne: " j223yang
2011-03-10 22:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310.144034.39174581.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=j223yang@asset.uwaterloo.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).