* [Patch]ariadne: remove redundant NULL check
@ 2011-03-10 17:20 j223yang
2011-03-10 22:12 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: j223yang @ 2011-03-10 17:20 UTC (permalink / raw)
To: davem, netdev; +Cc: linux-kernel
Simply remove redundant 'dev' NULL check.
Signed-off-by: Jinqiu Yang<crindy646@gmail.com>
---
ariadne.c | 5 -----
1 file changed, 5 deletions(-)
--- a/drivers/net/ariadne.c 2011-03-10 11:20:14.076039323 -0500
+++ b/drivers/net/ariadne.c 2011-03-10 11:21:59.111164537 -0500
@@ -425,11 +425,6 @@ static irqreturn_t ariadne_interrupt(int
int csr0, boguscnt;
int handled = 0;
- if (dev == NULL) {
- printk(KERN_WARNING "ariadne_interrupt(): irq for unknown device.\n");
- return IRQ_NONE;
- }
-
lance->RAP = CSR0; /* PCnet-ISA Controller Status */
if (!(lance->RDP & INTR)) /* Check if any interrupt has been */
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch]ariadne: remove redundant NULL check
2011-03-10 17:20 [Patch]ariadne: " j223yang
@ 2011-03-10 22:12 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-03-10 22:12 UTC (permalink / raw)
To: j223yang; +Cc: netdev, linux-kernel
From: j223yang@asset.uwaterloo.ca
Date: Thu, 10 Mar 2011 12:20:31 -0500
> Simply remove redundant 'dev' NULL check.
>
> Signed-off-by: Jinqiu Yang<crindy646@gmail.com>
This patch was corrupted by your email client, it turned TAB
characters into spaces which makes the patch unusable.
Also your signoff is badly formed, a space is missing between
your name and the "<" that begins your email address.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch] ariadne: remove redundant NULL check
@ 2011-03-10 22:36 j223yang
2011-03-10 22:39 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: j223yang @ 2011-03-10 22:36 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel
Simply remove redundant 'dev' NULL check.
Source code uses spaces instead of TAB, except 'printk' and 'return' lines.
Signed-off-by: Jinqiu Yang <crindy646@gmail.com>
---
ariadne.c | 5 -----
1 file changed, 5 deletions(-)
--- a/drivers/net/ariadne.c 2011-03-10 11:20:14.076039323 -0500
+++ b/drivers/net/ariadne.c 2011-03-10 11:21:59.111164537 -0500
@@ -425,11 +425,6 @@ static irqreturn_t ariadne_interrupt(int
int csr0, boguscnt;
int handled = 0;
- if (dev == NULL) {
- printk(KERN_WARNING "ariadne_interrupt(): irq for unknown device.\n");
- return IRQ_NONE;
- }
-
lance->RAP = CSR0; /* PCnet-ISA Controller Status */
if (!(lance->RDP & INTR)) /* Check if any interrupt has been */
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ariadne: remove redundant NULL check
2011-03-10 22:36 [patch] ariadne: remove redundant NULL check j223yang
@ 2011-03-10 22:39 ` David Miller
2011-03-10 22:40 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2011-03-10 22:39 UTC (permalink / raw)
To: j223yang; +Cc: netdev, linux-kernel
From: j223yang@asset.uwaterloo.ca
Date: Thu, 10 Mar 2011 17:36:37 -0500
> Simply remove redundant 'dev' NULL check.
> Source code uses spaces instead of TAB, except 'printk' and 'return' lines.
>
>
> Signed-off-by: Jinqiu Yang <crindy646@gmail.com>
Patch is still corrupted by your email client, the same way as before.
And when you fix it, you don't need to mention this in the commit
message.
Please, take the time to do some testing by sending the patch to
yourself, and then try to apply the patch in the email you receive.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ariadne: remove redundant NULL check
2011-03-10 22:39 ` David Miller
@ 2011-03-10 22:40 ` David Miller
2011-03-11 9:57 ` Nicolas Kaiser
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2011-03-10 22:40 UTC (permalink / raw)
To: j223yang; +Cc: netdev, linux-kernel
From: David Miller <davem@davemloft.net>
Date: Thu, 10 Mar 2011 14:39:42 -0800 (PST)
> From: j223yang@asset.uwaterloo.ca
> Date: Thu, 10 Mar 2011 17:36:37 -0500
>
>> Simply remove redundant 'dev' NULL check.
>> Source code uses spaces instead of TAB, except 'printk' and 'return' lines.
>>
>>
>> Signed-off-by: Jinqiu Yang <crindy646@gmail.com>
>
> Patch is still corrupted by your email client, the same way as before.
Sorry, I apologize, this is not your fault.
This is one of those terrible old drivers that have bad coding
style.
I'll apply this patch, thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ariadne: remove redundant NULL check
2011-03-10 22:40 ` David Miller
@ 2011-03-11 9:57 ` Nicolas Kaiser
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Kaiser @ 2011-03-11 9:57 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel, j223yang
* David Miller <davem@davemloft.net>:
> This is one of those terrible old drivers that have bad coding
> style.
Would you like a cleanup patch for this driver?
Best regards,
Nicolas Kaiser
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-11 9:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-10 22:36 [patch] ariadne: remove redundant NULL check j223yang
2011-03-10 22:39 ` David Miller
2011-03-10 22:40 ` David Miller
2011-03-11 9:57 ` Nicolas Kaiser
-- strict thread matches above, loose matches on Subject: below --
2011-03-10 17:20 [Patch]ariadne: " j223yang
2011-03-10 22:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).