From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Iles Subject: Re: [PATCH 1/8] macb: unify at91 and avr32 platform data Date: Thu, 10 Mar 2011 13:17:24 +0000 Message-ID: <20110310131724.GG6198@pulham.picochip.com> References: <1299751843-9743-1-git-send-email-jamie@jamieiles.com> <1299751843-9743-2-git-send-email-jamie@jamieiles.com> <4D78CCBC.2010807@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jamie Iles , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Nicolas Ferre Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:44904 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435Ab1CJNRj (ORCPT ); Thu, 10 Mar 2011 08:17:39 -0500 Received: by wya21 with SMTP id 21so1419375wya.19 for ; Thu, 10 Mar 2011 05:17:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <4D78CCBC.2010807@atmel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Mar 10, 2011 at 02:06:04PM +0100, Nicolas Ferre wrote: > On 3/10/2011 11:10 AM, Jamie Iles : > > --- a/drivers/net/macb.c > > +++ b/drivers/net/macb.c > > @@ -18,12 +18,10 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > -#include > > -#include > > I did not bouble check but do we need no more cpu_is_ macros? No, I couldn't see any in there and it builds for all of the AT91 targets and all of the AVR32 ones that I tried. I can't see any macros in there that are likely to use cpu_is_* internally either. Jamie