From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCH 4/8] macb: initial support for Cadence GEM Date: Fri, 11 Mar 2011 14:14:15 +0100 Message-ID: <20110311131415.GO9351@game.jcrosoft.org> References: <1299751843-9743-1-git-send-email-jamie@jamieiles.com> <1299751843-9743-5-git-send-email-jamie@jamieiles.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nicolas.ferre@atmel.com To: Jamie Iles Return-path: Received: from 64.mail-out.ovh.net ([91.121.185.65]:47420 "HELO 64.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753878Ab1CKNTo (ORCPT ); Fri, 11 Mar 2011 08:19:44 -0500 Content-Disposition: inline In-Reply-To: <1299751843-9743-5-git-send-email-jamie@jamieiles.com> Sender: netdev-owner@vger.kernel.org List-ID: On 10:10 Thu 10 Mar , Jamie Iles wrote: > The Cadence GEM is based on the MACB Ethernet controller but has a few > small changes with regards to register and bitfield placement. This > patch adds a new platform driver for gem which sets allows the driver to > tell at runtime whether it is targetting a GEM device. > > Signed-off-by: Jamie Iles could we avoid all this if else everywhere? Best Regards, J.