From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Iles Subject: Re: [PATCH 1/8] macb: unify at91 and avr32 platform data Date: Fri, 11 Mar 2011 13:53:35 +0000 Message-ID: <20110311135335.GG7357@pulham.picochip.com> References: <1299751843-9743-1-git-send-email-jamie@jamieiles.com> <1299751843-9743-2-git-send-email-jamie@jamieiles.com> <4D78CCBC.2010807@atmel.com> <20110310131724.GG6198@pulham.picochip.com> <20110311014140.GI9351@game.jcrosoft.org> <20110311085605.GK6198@pulham.picochip.com> <20110311125246.GL9351@game.jcrosoft.org> <20110311132536.GE7357@pulham.picochip.com> <20110311133713.GQ9351@game.jcrosoft.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jamie Iles , Nicolas Ferre , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Jean-Christophe PLAGNIOL-VILLARD Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:48127 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753771Ab1CKNxj (ORCPT ); Fri, 11 Mar 2011 08:53:39 -0500 Received: by bwz15 with SMTP id 15so2682904bwz.19 for ; Fri, 11 Mar 2011 05:53:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <20110311133713.GQ9351@game.jcrosoft.org> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Mar 11, 2011 at 02:37:13PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 13:25 Fri 11 Mar , Jamie Iles wrote: > > On Fri, Mar 11, 2011 at 01:52:46PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > On 08:56 Fri 11 Mar , Jamie Iles wrote: > > > > On Fri, Mar 11, 2011 at 02:41:40AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > > keep as we need to remove the #ifdef AT91 to cpu_is > > > > > > > > > > I've patch for this > > > > > > > > Is this for the user IO register where the value written is conditional > > > > on both RMII/MII and arch type? > > > yes for > > > > > > #if defined(CONFIG_ARCH_AT91) > > > macb_writel(bp, USRIO, (MACB_BIT(RMII) | MACB_BIT(CLKEN))); > > > #else > > > macb_writel(bp, USRIO, 0); > > > #endif > > > else > > > #if defined(CONFIG_ARCH_AT91) > > > macb_writel(bp, USRIO, MACB_BIT(CLKEN)); > > > #else > > > macb_writel(bp, USRIO, MACB_BIT(MII)); > > > #endif > > > > Ok, but what about non-AT91/AVR32 systems? They may not have a > > mach/cpu.h and won't have cpu_is_foo() for the platforms the driver is > > interested in. > > > > Could we supply these values in the platform data so the driver doesn't > > need to do any cpu_is_ magic? > > for other arch you can but at91 I prefer to avoid this copy and paste in every > soc Ok, just so I'm clear, you want to be able to set the USRIO register based on a cpu_is_foo() test which requires mach/cpu.h to be included. For other architectures we may not have mach/cpu.h and the cpu_is_foo() macros, so we'd still need to protect all of that with "#ifdef CONFIG_ARCH_AT91" tests. Is that okay? Jamie