From: David Miller <davem@davemloft.net>
To: shimoda.hiroaki@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] ipv4: Fix PMTU update.
Date: Sun, 13 Mar 2011 18:38:45 -0700 (PDT) [thread overview]
Message-ID: <20110313.183845.226774350.davem@davemloft.net> (raw)
In-Reply-To: <20110310150958.123c9f7f.shimoda.hiroaki@gmail.com>
From: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Date: Thu, 10 Mar 2011 15:09:58 +0900
> On current net-next-2.6, when Linux receives ICMP Type: 3, Code: 4
> (Destination unreachable (Fragmentation needed)),
>
> icmp_unreach
> -> ip_rt_frag_needed
> (peer->pmtu_expires is set here)
> -> tcp_v4_err
> -> do_pmtu_discovery
> -> ip_rt_update_pmtu
> (peer->pmtu_expires is already set,
> so check_peer_pmtu is skipped.)
> -> check_peer_pmtu
>
> check_peer_pmtu is skipped and MTU is not updated.
>
> To fix this, let check_peer_pmtu execute unconditionally.
> And some minor fixes
> 1) Avoid potential peer->pmtu_expires set to be zero.
> 2) In check_peer_pmtu, argument of time_before is reversed.
> 3) check_peer_pmtu expects peer->pmtu_orig is initialized as zero,
> but not initialized.
>
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
This looks great, thanks for fixing this bug.
Applied.
prev parent reply other threads:[~2011-03-14 1:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 6:09 [PATCH net-next-2.6] ipv4: Fix PMTU update Hiroaki SHIMODA
2011-03-14 1:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110313.183845.226774350.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shimoda.hiroaki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).