From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: daniel.turull@gmail.com, netdev@vger.kernel.org,
robert@herjulf.net, jens.laas@its.uu.se, voravit@kth.se
Subject: Re: [PATCH net-next-2.6] pktgen: bug fix in transmission headers with frags=0
Date: Mon, 14 Mar 2011 13:47:51 -0700 (PDT) [thread overview]
Message-ID: <20110314.134751.104044608.davem@davemloft.net> (raw)
In-Reply-To: <1300113350.3423.32.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 14 Mar 2011 15:35:50 +0100
> Le lundi 14 mars 2011 à 15:31 +0100, Daniel Turull a écrit :
>> (bug introduced by commit 26ad787962ef84677a48c560
>> (pktgen: speedup fragmented skbs)
>>
>> The headers of pktgen were incorrectly added in a pktgen packet
>> without frags (frags=0). There was an offset in the pktgen headers.
>>
>> The cause was in reusing the pgh variable as a return variable in skb_put
>> when adding the payload to the skb.
>>
>> Signed-off-by: Daniel Turull <daniel.turull@gmail.com>
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
prev parent reply other threads:[~2011-03-14 20:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 13:22 [PATCH] pktgen: fix transmission headers with frags=0 Daniel Turull
2011-03-14 13:56 ` Eric Dumazet
2011-03-14 14:13 ` Daniel Turull
2011-03-14 14:18 ` Eric Dumazet
2011-03-14 14:31 ` [PATCH net-next-2.6] pktgen: bug fix in " Daniel Turull
2011-03-14 14:35 ` Eric Dumazet
2011-03-14 20:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314.134751.104044608.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel.turull@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=jens.laas@its.uu.se \
--cc=netdev@vger.kernel.org \
--cc=robert@herjulf.net \
--cc=voravit@kth.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).