* [PATCH] xen: netfront: ethtool stats fields should be unsigned long
@ 2011-03-10 17:04 Ian Campbell
2011-03-14 22:10 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Ian Campbell @ 2011-03-10 17:04 UTC (permalink / raw)
To: netdev; +Cc: Jeremy Fitzhardinge, Ian Campbell, Ben Hutchings
Fixup the rx_gso_checksum_fixup field added in e0ce4af920eb to be
unsigned long as suggested by Ben Hutchings in
<1298919198.2569.14.camel@bwh-desktop>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/xen-netfront.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index a6ab973..df45323 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -122,7 +122,7 @@ struct netfront_info {
struct mmu_update rx_mmu[NET_RX_RING_SIZE];
/* Statistics */
- int rx_gso_checksum_fixup;
+ unsigned long rx_gso_checksum_fixup;
};
struct netfront_rx_info {
--
1.5.6.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] xen: netfront: ethtool stats fields should be unsigned long
2011-03-10 17:04 [PATCH] xen: netfront: ethtool stats fields should be unsigned long Ian Campbell
@ 2011-03-14 22:10 ` David Miller
2011-03-15 3:50 ` Eric Dumazet
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2011-03-14 22:10 UTC (permalink / raw)
To: ian.campbell; +Cc: netdev, jeremy, bhutchings
From: Ian Campbell <ian.campbell@citrix.com>
Date: Thu, 10 Mar 2011 17:04:18 +0000
> Fixup the rx_gso_checksum_fixup field added in e0ce4af920eb to be
> unsigned long as suggested by Ben Hutchings in
> <1298919198.2569.14.camel@bwh-desktop>
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Applied, thanks Ian.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen: netfront: ethtool stats fields should be unsigned long
2011-03-14 22:10 ` David Miller
@ 2011-03-15 3:50 ` Eric Dumazet
2011-03-15 4:06 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Eric Dumazet @ 2011-03-15 3:50 UTC (permalink / raw)
To: David Miller; +Cc: ian.campbell, netdev, jeremy, bhutchings
Le lundi 14 mars 2011 à 15:10 -0700, David Miller a écrit :
> From: Ian Campbell <ian.campbell@citrix.com>
> Date: Thu, 10 Mar 2011 17:04:18 +0000
>
> > Fixup the rx_gso_checksum_fixup field added in e0ce4af920eb to be
> > unsigned long as suggested by Ben Hutchings in
> > <1298919198.2569.14.camel@bwh-desktop>
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Applied, thanks Ian.
Hmm, this needs this followup patch then.
Thanks
[PATCH] xen: netfront: fix xennet_get_ethtool_stats()
commit e9a799ea4a5551d2 (xen: netfront: ethtool stats fields should be
unsigned long) made rx_gso_checksum_fixup an unsigned long.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/xen-netfront.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 27cf72f..5b399b5 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1692,7 +1692,7 @@ static void xennet_get_ethtool_stats(struct net_device *dev,
int i;
for (i = 0; i < ARRAY_SIZE(xennet_stats); i++)
- data[i] = *(int *)(np + xennet_stats[i].offset);
+ data[i] = *(unsigned long *)(np + xennet_stats[i].offset);
}
static void xennet_get_strings(struct net_device *dev, u32 stringset, u8 * data)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xen: netfront: ethtool stats fields should be unsigned long
2011-03-15 3:50 ` Eric Dumazet
@ 2011-03-15 4:06 ` David Miller
2011-03-15 7:12 ` Ian Campbell
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2011-03-15 4:06 UTC (permalink / raw)
To: eric.dumazet; +Cc: ian.campbell, netdev, jeremy, bhutchings
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 15 Mar 2011 04:50:43 +0100
> Le lundi 14 mars 2011 à 15:10 -0700, David Miller a écrit :
>> From: Ian Campbell <ian.campbell@citrix.com>
>> Date: Thu, 10 Mar 2011 17:04:18 +0000
>>
>> > Fixup the rx_gso_checksum_fixup field added in e0ce4af920eb to be
>> > unsigned long as suggested by Ben Hutchings in
>> > <1298919198.2569.14.camel@bwh-desktop>
>> >
>> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>>
>> Applied, thanks Ian.
>
> Hmm, this needs this followup patch then.
>
> Thanks
>
> [PATCH] xen: netfront: fix xennet_get_ethtool_stats()
>
> commit e9a799ea4a5551d2 (xen: netfront: ethtool stats fields should be
> unsigned long) made rx_gso_checksum_fixup an unsigned long.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
I even saw your feedback but for some reason I still applied
his patch, sorry about that :-)
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen: netfront: ethtool stats fields should be unsigned long
2011-03-15 4:06 ` David Miller
@ 2011-03-15 7:12 ` Ian Campbell
0 siblings, 0 replies; 5+ messages in thread
From: Ian Campbell @ 2011-03-15 7:12 UTC (permalink / raw)
To: David Miller
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, jeremy@goop.org,
bhutchings@solarflare.com
On Tue, 2011-03-15 at 04:06 +0000, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 15 Mar 2011 04:50:43 +0100
>
> > Le lundi 14 mars 2011 à 15:10 -0700, David Miller a écrit :
> >> From: Ian Campbell <ian.campbell@citrix.com>
> >> Date: Thu, 10 Mar 2011 17:04:18 +0000
> >>
> >> > Fixup the rx_gso_checksum_fixup field added in e0ce4af920eb to be
> >> > unsigned long as suggested by Ben Hutchings in
> >> > <1298919198.2569.14.camel@bwh-desktop>
> >> >
> >> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> >>
> >> Applied, thanks Ian.
> >
> > Hmm, this needs this followup patch then.
> >
> > Thanks
> >
> > [PATCH] xen: netfront: fix xennet_get_ethtool_stats()
> >
> > commit e9a799ea4a5551d2 (xen: netfront: ethtool stats fields should be
> > unsigned long) made rx_gso_checksum_fixup an unsigned long.
> >
> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> I even saw your feedback but for some reason I still applied
> his patch, sorry about that :-)
>
> Applied, thanks.
His feed back was for netback and this was a netfront patch, but I
didn't make the link either.
Thanks for picking it up Eric.
Ian.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-15 7:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-10 17:04 [PATCH] xen: netfront: ethtool stats fields should be unsigned long Ian Campbell
2011-03-14 22:10 ` David Miller
2011-03-15 3:50 ` Eric Dumazet
2011-03-15 4:06 ` David Miller
2011-03-15 7:12 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).