From: David Miller <davem@davemloft.net>
To: remi.denis-courmont@nokia.com
Cc: jslaby@suse.cz, jirislaby@gmail.com, netdev@vger.kernel.org,
gregkh@suse.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] NET: cdc-phonet, handle empty phonet header
Date: Mon, 14 Mar 2011 15:24:29 -0700 (PDT) [thread overview]
Message-ID: <20110314.152429.191392418.davem@davemloft.net> (raw)
In-Reply-To: <201103140949.04760.remi.denis-courmont@nokia.com>
From: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Date: Mon, 14 Mar 2011 09:49:04 +0200
> On Sunday 13 March 2011 18:54:31 ext Jiri Slaby, you wrote:
>> Currently, for N 5800 XM I get:
>> cdc_phonet: probe of 1-6:1.10 failed with error -22
>>
>> It's because phonet_header is empty. Extra altsetting looks like
>> there:
>> E 05 24 00 01 10 03 24 ab 05 24 06 0a 0b 04 24 fd .$....$..$....$.
>> E 00 .
>>
>> I don't see the header used anywhere so just check if the phonet
>> descriptor is there, not the structure itself.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> Cc: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
>> Cc: David S. Miller <davem@davemloft.net>
>
> Acked-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Also applied, thanks.
next prev parent reply other threads:[~2011-03-14 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 16:54 [PATCH 1/2] NET: cdc-phonet, fix stop-queue handling Jiri Slaby
2011-03-13 16:54 ` [PATCH 2/2] NET: cdc-phonet, handle empty phonet header Jiri Slaby
[not found] ` <1300035271-8138-2-git-send-email-jslaby-AlSwsSmVLrQ@public.gmane.org>
2011-03-14 7:49 ` Rémi Denis-Courmont
2011-03-14 22:24 ` David Miller [this message]
2011-03-14 7:39 ` [PATCH 1/2] NET: cdc-phonet, fix stop-queue handling Rémi Denis-Courmont
2011-03-14 22:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314.152429.191392418.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).