netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: huzaifas@redhat.com
Cc: netdev@vger.kernel.org, leitao@linux.vnet.ibm.com
Subject: Re: [PATCH] Fix possible null pointer dereference in ehea_qmr.c
Date: Mon, 14 Mar 2011 15:34:56 -0700 (PDT)	[thread overview]
Message-ID: <20110314.153456.52185310.davem@davemloft.net> (raw)
In-Reply-To: <1300088764-9330-1-git-send-email-huzaifas@redhat.com>

From: huzaifas@redhat.com
Date: Mon, 14 Mar 2011 13:16:04 +0530

> From: Huzaifa Sidhpurwala <huzaifas@redhat.com>
> 
> If queue is zero, dont reference it
> 
> Signed-off-by: Huzaifa Sidhpurwala <huzaifas@redhat.com>

There is no code path where hw_queue_dtor() is called with a NULL
"queue".  I've checked all of the code paths.

Therefore it's better to simply remove the NULL check.

      reply	other threads:[~2011-03-14 22:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-14  7:46 [PATCH] Fix possible null pointer dereference in ehea_qmr.c huzaifas
2011-03-14 22:34 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110314.153456.52185310.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=huzaifas@redhat.com \
    --cc=leitao@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).