From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: amit.salecha@qlogic.com, netdev@vger.kernel.org,
ameen.rahman@qlogic.com, anirban.chakraborty@qlogic.com,
sony.chacko@qlogic.com
Subject: Re: [PATCH NEXT 2/2] netxen: support for GbE port settings
Date: Mon, 14 Mar 2011 15:54:20 -0700 (PDT) [thread overview]
Message-ID: <20110314.155420.57460529.davem@davemloft.net> (raw)
In-Reply-To: <1300142648.2584.76.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 14 Mar 2011 22:44:08 +0000
> For link settings, that isn't clear, and drivers should simply
> reject invalid combinations.
Ok, makes sense.
Amit please update your patch to silently reject link setting attempts
that are unsupported by the device.
Thanks.
next prev parent reply other threads:[~2011-03-14 22:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 9:50 [PATCH NEXT 0/2]nexten: bug fixes Amit Kumar Salecha
2011-03-11 9:50 ` [PATCH NEXT 1/2] netxen: Notify firmware of Flex-10 interface down Amit Kumar Salecha
2011-03-14 22:14 ` David Miller
2011-03-11 9:50 ` [PATCH NEXT 2/2] netxen: support for GbE port settings Amit Kumar Salecha
2011-03-14 22:15 ` David Miller
2011-03-14 22:30 ` Ben Hutchings
2011-03-14 22:32 ` David Miller
2011-03-14 22:44 ` Ben Hutchings
2011-03-14 22:54 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-03-11 10:44 [PATCH NEXT 0/2]nexten: bug fixes Amit Kumar Salecha
2011-03-11 10:44 ` [PATCH NEXT 2/2] netxen: support for GbE port settings Amit Kumar Salecha
2011-04-11 22:56 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314.155420.57460529.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ameen.rahman@qlogic.com \
--cc=amit.salecha@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).