From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: chromatix99@gmail.com, d@taht.net, netdev@vger.kernel.org,
dan@coverfire.com
Subject: Re: [PATCH] net_sched: fix ip_tos2prio
Date: Tue, 15 Mar 2011 18:54:24 -0700 (PDT) [thread overview]
Message-ID: <20110315.185424.193707215.davem@davemloft.net> (raw)
In-Reply-To: <1300233367.2565.133.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 16 Mar 2011 00:56:07 +0100
> From: Dan Siemon <dan@coverfire.com>
>
> ECN support incorrectly maps ECN BESTEFFORT packets to TC_PRIO_FILLER
> (1) instead of TC_PRIO_BESTEFFORT (0)
>
> This means ECN enabled flows are placed in pfifo_fast/prio low priority
> band, giving ECN enabled flows [ECT(0) and CE codepoints] higher drop
> probabilities.
>
> This is rather unfortunate, given we would like ECN being more widely
> used.
>
> Ref : http://www.coverfire.com/archives/2011/03/13/pfifo_fast-and-ecn/
>
> Signed-off-by: Dan Siemon <dan@coverfire.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Dave Täht <d@taht.net>
> Cc: Jonathan Morton <chromatix99@gmail.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2011-03-16 1:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87wrk1a4gx.fsf@cruithne.co.teklibre.org>
[not found] ` <5BC42741-852B-4699-BA5D-D70B8D610D96@gmail.com>
2011-03-14 20:24 ` [Bloat] shaper team forming up Eric Dumazet
2011-03-15 4:42 ` Eric Dumazet
2011-03-15 5:27 ` ECN + pfifo_fast borked? (Was Re: [Bloat] shaper team forming up) Dave Täht
2011-03-15 6:15 ` Eric Dumazet
2011-03-15 17:09 ` Jonathan Morton
2011-03-15 18:28 ` Eric Dumazet
2011-03-15 18:37 ` Jonathan Morton
2011-03-15 19:56 ` Eric Dumazet
2011-03-15 22:51 ` [Bloat] shaper team forming up David Miller
2011-03-15 22:53 ` David Miller
2011-03-15 23:00 ` Eric Dumazet
2011-03-15 23:56 ` [PATCH] net_sched: fix ip_tos2prio Eric Dumazet
2011-03-16 1:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315.185424.193707215.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chromatix99@gmail.com \
--cc=d@taht.net \
--cc=dan@coverfire.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).