From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v6] xen network backend driver Date: Tue, 15 Mar 2011 19:38:55 -0700 (PDT) Message-ID: <20110315.193855.104049587.davem@davemloft.net> References: <1300183578.17339.2239.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, xen-devel@lists.xensource.com, jeremy@goop.org, herbert@gondor.apana.org.au, konrad.wilk@oracle.com, romieu@fr.zoreil.com, bhutchings@solarflare.com, shemminger@vyatta.com, mirqus@gmail.com, eric.dumazet@gmail.com To: Ian.Campbell@citrix.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:39020 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751840Ab1CPCiR (ORCPT ); Tue, 15 Mar 2011 22:38:17 -0400 In-Reply-To: <1300183578.17339.2239.camel@zakaz.uk.xensource.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Ian Campbell Date: Tue, 15 Mar 2011 10:06:18 +0000 > netback is the host side counterpart to the frontend driver in > drivers/net/xen-netfront.c. The PV protocol is also implemented by > frontend drivers in other OSes too, such as the BSDs and even Windows. > > The patch is based on the driver from the xen.git pvops kernel tree but > has been put through the checkpatch.pl wringer plus several manual > cleanup passes and review iterations. The driver has been moved from > drivers/xen/netback to drivers/net/xen-netback. > > One major change from xen.git is that the guest transmit path (i.e. what > looks like receive to netback) has been significantly reworked to remove > the dependency on the out of tree PageForeign page flag (a core kernel > patch which enables a per page destructor callback on the final > put_page). This page flag was used in order to implement a grant map > based transmit path (where guest pages are mapped directly into SKB > frags). Instead this version of netback uses grant copy operations into > regular memory belonging to the backend domain. Reinstating the grant > map functionality is something which I would like to revisit in the > future. > > Note that this driver depends on 2e820f58f7ad "xen/irq: implement > bind_interdomain_evtchn_to_irqhandler for backend drivers" which is in > linux next via the "xen-two" tree and is intended for the 2.6.39 merge > window: > git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git stable/backends > this branch has only that single commit since 2.6.38-rc2 and is safe for > cross merging into the net branch. > > Signed-off-by: Ian Campbell > Reviewed-by: Ben Hutchings Ok, I merged that xen commit into my tree and then added this driver. Thanks.