From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCHv2 4/9] macb: convert printk to netdev_ and friends Date: Tue, 15 Mar 2011 13:36:51 +0100 Message-ID: <20110315123651.GF14548@game.jcrosoft.org> References: <1300184096-13937-1-git-send-email-jamie@jamieiles.com> <1300184096-13937-5-git-send-email-jamie@jamieiles.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org To: Jamie Iles Return-path: Content-Disposition: inline In-Reply-To: <1300184096-13937-5-git-send-email-jamie@jamieiles.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org On 10:14 Tue 15 Mar , Jamie Iles wrote: > macb is already using the dev_dbg() and friends helpers so use netdev_() > along with a pr_fmt() definition to make the printing a little cleaner. > > Signed-off-by: Jamie Iles looks fine Acked-by: Jean-Christophe PLAGNIOL-VILLARD Best Regards, J.