netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Iles <jamie@jamieiles.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Jamie Iles <jamie@jamieiles.com>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	nicolas.ferre@atmel.com
Subject: Re: [PATCHv2 1/9] at91: provide macb clks with "pclk" and "hclk" name
Date: Tue, 15 Mar 2011 12:44:16 +0000	[thread overview]
Message-ID: <20110315124416.GG2914@pulham.picochip.com> (raw)
In-Reply-To: <20110315123539.GD14548@game.jcrosoft.org>

On Tue, Mar 15, 2011 at 01:35:39PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:14 Tue 15 Mar     , Jamie Iles wrote:
> > The macb driver expects clocks with the names "pclk" and "hclk".  We
> > currently provide "macb_clk" but to fit in line with other
> > architectures (namely AVR32), provide "pclk" and a fake "hclk".
> > 
> > Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> > ---
> >  arch/arm/mach-at91/at572d940hf.c |    8 +++++++-
> >  arch/arm/mach-at91/at91cap9.c    |    8 +++++++-
> >  arch/arm/mach-at91/at91sam9260.c |    8 +++++++-
> >  arch/arm/mach-at91/at91sam9263.c |    8 +++++++-
> >  arch/arm/mach-at91/at91sam9g45.c |    8 +++++++-
> >  5 files changed, 35 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/arm/mach-at91/at572d940hf.c b/arch/arm/mach-at91/at572d940hf.c
> > index a6b9c68..9b3a37e 100644
> > --- a/arch/arm/mach-at91/at572d940hf.c
> > +++ b/arch/arm/mach-at91/at572d940hf.c
> > @@ -71,10 +71,15 @@ static struct clk pioC_clk = {
> >  	.type		= CLK_TYPE_PERIPHERAL,
> >  };
> >  static struct clk macb_clk = {
> > -	.name		= "macb_clk",
> > +	.name		= "pclk",
> >  	.pmc_mask	= 1 << AT572D940HF_ID_EMAC,
> >  	.type		= CLK_TYPE_PERIPHERAL,
> >  };
> > +static struct clk macb_hclk = {
> > +	.name		= "hclk",
> > +	.pmc_mask	= 0,
> > +	.type		= CLK_TYPE_PERIPHERAL,
> > +};
> for the fake clock you must specify the parent as macb_clk
> 
> take a look on the tcb1_clk for the 9g45

Ok, will do.  Thanks for the pointer!

Jamie

  reply	other threads:[~2011-03-15 12:44 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15 10:14 [PATCHv2 0/9] macb: add support for Cadence GEM Jamie Iles
2011-03-15 10:14 ` [PATCHv2 1/9] at91: provide macb clks with "pclk" and "hclk" name Jamie Iles
2011-03-15 12:35   ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 12:44     ` Jamie Iles [this message]
2011-03-16  6:53   ` avictor.za
2011-03-16  8:38     ` Russell King - ARM Linux
2011-03-17  9:22       ` Andrew Victor
2011-03-17 10:00         ` Russell King - ARM Linux
2011-03-17 10:09           ` Jamie Iles
2011-03-15 10:14 ` [PATCHv2 2/9] macb: remove conditional clk handling Jamie Iles
2011-03-15 10:14 ` [PATCHv2 3/9] macb: unify at91 and avr32 platform data Jamie Iles
2011-03-15 11:14   ` Peter Korsgaard
2011-03-15 11:34     ` Jamie Iles
2011-03-15 12:36     ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-17  8:43     ` avictor.za
2011-03-17  8:48       ` Peter Korsgaard
2011-03-17  8:58         ` Russell King - ARM Linux
2011-03-17  9:22           ` Peter Korsgaard
2011-03-17  9:34             ` Jamie Iles
2011-03-17 21:51               ` Jamie Iles
2011-03-18 15:41                 ` Russell King - ARM Linux
2011-03-18 15:48                   ` Jamie Iles
2011-03-18 15:54                     ` Russell King - ARM Linux
2011-03-19 15:49                       ` Nicolas Ferre
2011-04-23  5:48                       ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 10:14 ` [PATCHv2 4/9] macb: convert printk to netdev_ and friends Jamie Iles
2011-03-15 12:36   ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 10:14 ` [PATCHv2 5/9] macb: initial support for Cadence GEM Jamie Iles
2011-03-15 10:14 ` [PATCHv2 6/9] macb: support higher rate GEM MDIO clock divisors Jamie Iles
2011-03-15 10:14 ` [PATCHv2 7/9] macb: support statistics for GEM devices Jamie Iles
2011-03-15 10:14 ` [PATCHv2 8/9] macb: support DMA bus widths > 32 bits Jamie Iles
2011-03-15 10:14 ` [PATCHv2 9/9] macb: allow GEM to have configurable receive buffer size Jamie Iles
2011-03-16 20:17 ` [PATCHv2 0/9] macb: add support for Cadence GEM David Miller
2011-03-21  6:38   ` Nicolas Ferre
2011-03-21 11:18     ` Jamie Iles
2011-03-22 16:18       ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-22 16:39         ` Jamie Iles
2011-03-22 17:55           ` Jamie Iles
2011-03-24 16:25             ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-31  9:40               ` Jamie Iles
2011-04-05 10:28                 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 10:49                   ` Jamie Iles
2011-04-05 11:21                     ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 11:47                       ` Jamie Iles
2011-04-05 11:57                         ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 11:12                   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110315124416.GG2914@pulham.picochip.com \
    --to=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).