* [PATCH net-next-2.6] bonding: enable netpoll without checking link status
@ 2011-03-14 22:05 Andy Gospodarek
2011-03-16 19:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andy Gospodarek @ 2011-03-14 22:05 UTC (permalink / raw)
To: netdev; +Cc: WANG Cong, fubar
Only slaves that are up should transmit netpoll frames, so there is no
need to check to see if a slave is up before enabling netpoll on it.
This resolves a reported failure on active-backup bonds where a slave
interface is down when netpoll was enabled.
Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
Tested-by: WANG Cong <amwang@redhat.com>
---
drivers/net/bonding/bond_main.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 7b7ca97..b14c377 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1352,8 +1352,6 @@ static int bond_netpoll_setup(struct net_device *dev, struct netpoll_info *ni)
read_lock(&bond->lock);
bond_for_each_slave(bond, slave, i) {
- if (!IS_UP(slave->dev))
- continue;
err = slave_enable_netpoll(slave);
if (err) {
__bond_netpoll_cleanup(bond);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next-2.6] bonding: enable netpoll without checking link status
2011-03-14 22:05 [PATCH net-next-2.6] bonding: enable netpoll without checking link status Andy Gospodarek
@ 2011-03-16 19:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-03-16 19:58 UTC (permalink / raw)
To: andy; +Cc: netdev, amwang, fubar
From: Andy Gospodarek <andy@greyhouse.net>
Date: Mon, 14 Mar 2011 18:05:21 -0400
> Only slaves that are up should transmit netpoll frames, so there is no
> need to check to see if a slave is up before enabling netpoll on it.
> This resolves a reported failure on active-backup bonds where a slave
> interface is down when netpoll was enabled.
>
> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
> Tested-by: WANG Cong <amwang@redhat.com>
Applied, thanks Andy.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-16 19:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-14 22:05 [PATCH net-next-2.6] bonding: enable netpoll without checking link status Andy Gospodarek
2011-03-16 19:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).