* Re: [PATCH 28/36] net,rcu: convert call_rcu(phonet_device_rcu_free) to kfree_rcu()
[not found] <4D82DADF.4010802@cn.fujitsu.com>
@ 2011-03-18 8:27 ` Rémi Denis-Courmont
2011-03-18 19:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Rémi Denis-Courmont @ 2011-03-18 8:27 UTC (permalink / raw)
To: ext Lai Jiangshan
Cc: Paul E. McKenney, Ingo Molnar, David S. Miller, netdev,
linux-kernel
On Friday 18 March 2011 06:09:03 ext Lai Jiangshan, you wrote:
> The rcu callback phonet_device_rcu_free() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(phonet_device_rcu_free).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
In principles, that's fine with me. But I think David is not taking that kind
of not-a-fix patch at the moment...
--
Rémi Denis-Courmont
http://www.remlab.net/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 28/36] net,rcu: convert call_rcu(phonet_device_rcu_free) to kfree_rcu()
[not found] <4D82DADF.4010802@cn.fujitsu.com>
2011-03-18 8:27 ` [PATCH 28/36] net,rcu: convert call_rcu(phonet_device_rcu_free) to kfree_rcu() Rémi Denis-Courmont
@ 2011-03-18 19:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2011-03-18 19:37 UTC (permalink / raw)
To: laijs; +Cc: paulmck, mingo, remi.denis-courmont, netdev, linux-kernel
From: Lai Jiangshan <laijs@cn.fujitsu.com>
Date: Fri, 18 Mar 2011 12:09:03 +0800
>
>
> The rcu callback phonet_device_rcu_free() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(phonet_device_rcu_free).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 28/36] net,rcu: convert call_rcu(phonet_device_rcu_free) to kfree_rcu()
@ 2011-03-18 4:09 Lai Jiangshan
0 siblings, 0 replies; 3+ messages in thread
From: Lai Jiangshan @ 2011-03-18 4:09 UTC (permalink / raw)
To: Paul E. McKenney, Ingo Molnar, Remi Denis-Courmont,
David S. Miller, netdev
The rcu callback phonet_device_rcu_free() just calls a kfree(),
so we use kfree_rcu() instead of the call_rcu(phonet_device_rcu_free).
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
net/phonet/pn_dev.c | 10 +---------
1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/net/phonet/pn_dev.c b/net/phonet/pn_dev.c
index 947038d..1566672 100644
--- a/net/phonet/pn_dev.c
+++ b/net/phonet/pn_dev.c
@@ -162,14 +162,6 @@ int phonet_address_add(struct net_device *dev, u8 addr)
return err;
}
-static void phonet_device_rcu_free(struct rcu_head *head)
-{
- struct phonet_device *pnd;
-
- pnd = container_of(head, struct phonet_device, rcu);
- kfree(pnd);
-}
-
int phonet_address_del(struct net_device *dev, u8 addr)
{
struct phonet_device_list *pndevs = phonet_device_list(dev_net(dev));
@@ -188,7 +180,7 @@ int phonet_address_del(struct net_device *dev, u8 addr)
mutex_unlock(&pndevs->lock);
if (pnd)
- call_rcu(&pnd->rcu, phonet_device_rcu_free);
+ kfree_rcu(pnd, rcu);
return err;
}
--
1.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-18 19:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4D82DADF.4010802@cn.fujitsu.com>
2011-03-18 8:27 ` [PATCH 28/36] net,rcu: convert call_rcu(phonet_device_rcu_free) to kfree_rcu() Rémi Denis-Courmont
2011-03-18 19:37 ` David Miller
2011-03-18 4:09 Lai Jiangshan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).